1948882 - With Layer Compositor enabled, Flash of black when opening the bookmarks menu

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Mayank Bansal]

Use fresh profile
Enable layer compositor
import the attached bookmark.html
Make sure that you have the bookmark "star" button in the toolbar.
Open the bookmark menu by clicking on the "star" button on the toolbar

AR: Flash of balck border before the bookmark menu is opened
ER: Not so

I havent dont a bisection, but Bug 1948565 seems the most likely to have caused this regression.

Comment 1

[Mayank Bansal]

Attachment: Flash of black.mp4

Comment 2

[Mayank Bansal]

Bisection:

Bug 1948565 - Allow accelerating semi-transparent windows popups. r=win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D238405

Also adding dependency on bug 1945683

Comment 3

[Mayank Bansal]

Attachment: bookmarks.html

Import this list of bookamrks.

Comment 4

[Mayank Bansal]

Attachment: about:support

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Glenn, this looks layer compositor specific, any chance you could take a look?

I made our popups use the regular accelerated widget codepath on windows (already the case on Linux). Looks similar to bug 1946487.

I'm also confused about https://phabricator.services.mozilla.com/D232273, isn't that patch a no-op? You didn't remove the if use_layer_compositor { on top.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

If needed we can temporarily revert or so of course...

Comment 7

[Glenn Watson [:gw]]

No need to revert, I'll add this to the list of bugs we need to solve before we enable layer-compositor.

Comment 8

[Glenn Watson [:gw]]

Attachment: Bug 1948882 - Fix incorrect opaque swapchain layer on empty composites of transparent windows

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2b0e84e5480
Fix incorrect opaque swapchain layer on empty composites of transparent windows r=gfx-reviewers,lsalzman

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f2b0e84e5480

Comment 11

[Mayank Bansal]

This is fixed in the latest Nightly.