1948884 - DLP icon not displayed on the browser toolbar when vertical tabs are enabled

Status: VERIFIED FIXED

(Firefox :: Data Loss Prevention, defect)

Description

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: screenshot

Found in

• 137.0a1 (2025-02-17)

Affected versions

• 137.0a1
• 136.0b6

Preconditions

• Download the DLP test assets from https://drive.google.com/file/d/1yjqVRuxdKV3WnO7D2wzMgDXBuYBxUgVw/view
• Create a distribution folder inside the Firefox folder and paste the policies-1.json to it and then rename it to policies.json
• Have the pref 'sidebar.verticalTabs' set to true or enable the vertical tabs from about:preferences#general - Browser layout section

Tested platforms

• Affected platforms: Windows 10/11
• Unaffected platforms: macOS, Ubuntu

Steps to reproduce

1. Launch Firefox and verify that the DLP icon is displayed on the right side of browser toolbar

Expected result

• The DLP icon should be displayed on the right side of the browser toolbar

Actual result

• The DLP icon is not displayed on the right side of the browser toolbar

Regression range

• N/A

Additional notes

• See the screenshot

Comment 1

[Greg Stoll :gstoll]

Attachment: DLP connection indicator with vertical tabs

Comment 2

[Greg Stoll :gstoll]

Attachment: DLP connection indicator with vertical tabs in private browsing mode

Comment 3

[Greg Stoll :gstoll]

Attachment: Bug 1948884 - make Content Analysis icon show up with vertical tabs r=#desktop-theme-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17c313d4588e
make Content Analysis icon show up with vertical tabs r=desktop-theme-reviewers,sfoster

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/17c313d4588e

Comment 6

[Greg Stoll :gstoll]

Attachment: Bug 1948884 - increase Content Analysis client buffer size r=#dlp-reviewers!

It's a bit unclear to me why this helps, since the logic seems to
indicate that ReadNextMessageFromPipe() will resize the buffer as
needed. But on my machine this makes a ~100 file upload work
consistently, where it would freeze sometimes before this change. And
it seems harmless.

Comment 7

[Greg Stoll :gstoll]

Attachment: Bug 1948884 part 2 - add patch for vendoring client_win.cc r=#dlp-reviewers!

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 137.0a1 (2025-02-26) on Windows 10x64 and Windows 11. The DLP icon is visible with vertical tabs enabled.