1950800 - More tools and Extension icons are overlapped in Private window with the browser's minimum width and vertical tabs

Status: VERIFIED FIXED

(Firefox :: Data Loss Prevention, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 137.0a1 (2025-02-26)

Affected versions

• 137.0a1 (2025-02-26)

Tested platforms

• Affected platforms: Windows 10x64, Windows 11
• Unaffected platforms: Ubuntu 24, macOS

Preconditions

• Download the DLP test assets from https://drive.google.com/file/d/1yjqVRuxdKV3WnO7D2wzMgDXBuYBxUgVw/view

• Create a distribution folder inside the Firefox folder and paste the policies-1.json to it and then rename it to policies.json

• DLP Agent is running: .\content_analysis_sdk_agent.exe --user --toblock=.*\d{3}-?\d{2}-?\d{4}.* --towarn=.*warn.* --delays=10

• vertical tabs enabled

Steps to reproduce

1. Open Firefox's private window.
2. Shrink the browser to the minimum width.

Expected result

• All buttons are correctly displayed.

Actual result

• Extensions and More tools buttons are overlapped.

Regression range

• Most likely this happens after bug 1948884.

Additional notes

• Attached a screenshot.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:gstoll, since you are the author of the regressor, bug 1948884, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Greg Stoll :gstoll]

Sigh, I tried this but I guess I was focused on the DLP icon and didn't see the overlap.

Comment 3

[Greg Stoll :gstoll]

Attachment: non-private window at minimum width with Content Analysis on

Comment 4

[Greg Stoll :gstoll]

Attachment: private window at minimum width with Content Analysis on

Comment 5

[Greg Stoll :gstoll]

Attachment: Bug 1950800 - make sure window width is big enough for Content Analysis icon with vertical tabs r=#desktop-theme-reviewers,#sidebar-reviewers

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1948884

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/789c64393b3b
make sure window width is big enough for Content Analysis icon with vertical tabs r=desktop-theme-reviewers,sidebar-reviewers,nsharpley,emilio

Comment 8

[amarc]

Backed out for causing linting failures

• Backout link
• Push with failures
• Failure Log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f6c91335cc8
make sure window width is big enough for Content Analysis icon with vertical tabs r=desktop-theme-reviewers,sidebar-reviewers,nsharpley,emilio

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2f6c91335cc8

Comment 11

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with 138.0a1 (2025-03-10) on Windows 10x64 and Windows 11.