1948954 - Profile name text error overlaps the Theme subheading

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect, P2)

Description

[Simona Badau, Desktop QA, PTO 22-30June]

Attachment: Screenshot with the issue

Found in

• Nightly 137.0a1

Affected versions

• Nightly 137.0a1

Tested platforms

• Affected platforms: Windows 11 x64, macOS 15

Steps to reproduce

1. In the "Open application menu" click on "Profiles".
2. From the "Profiles" menu click on "+New profile"
3. In the "about:newprofile" page click on "Done editing" button without giving a name to the profile.
4. Observe the "Name this profile" red error notification.

Expected result

• The "Need a name" error text notification is properly displayed.

Actual result

• The "Need a name" error text notification overlaps the Theme subheading.

Regression range
I could not use the mozregression tool as I could not enable Profiles there. I did a manual regression that led me to this pushlog:

• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ffddf6c98dc7cfec5eb11ceb7d16e9160165dfee&tochange=8e442c6e776594983158fd04b5331f1378f5f0dd
• Potentially regressed by: Bug 1936665

Additional notes

• The "Saved" notification that appears when a name is given, and the focus is moved out of the Profiles field also overlaps the Theme subheading.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:niklas, since you are the author of the regressor, bug 1936665, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Let's pull this little CSS fix into 0.5% scope

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1936665

Comment 4

[Pascal Chevrel (relman team) -> :pascalc]

Ciera, what is the status pf this bug wrt Fx 137? Thanks

Comment 5

[Cieara Meador [:cmkm]]

(In reply to Pascal Chevrel:pascalc from comment #4)

Ciera, what is the status pf this bug wrt Fx 137? Thanks

This will land in time for 138 but not 137.

Comment 6

[Pascal Chevrel (relman team) -> :pascalc]

Thanks

Comment 7

[Cieara Meador [:cmkm]]

Attachment: Bug 1948954 - Adjust profile manager text spacing r?#profiles-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e57e1e07edf
Adjust profile manager text spacing r=profiles-reviewers,niklas

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6e57e1e07edf

Comment 10

[Simona Badau, Desktop QA, PTO 22-30June]

Verified as fixed using the latest Nightly 138.0a1 on Windows 11 and macOS 15 - Profile name text error is not overlapping anymore.