1949180 - Switching panels while one is loading can end up displaying the wrong panel

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Alexandre Poirot [:ochameau]]

Most likely a regression from bug 1943543, but I didn't verify.

STR:

• run firefox with chaos mode
• open devtools on netmonitor
• quickly open the styleeditor while netmonitor is still loading and quickly select netmonitor back

After a few seconds, the styleditor will be shown while you selected the netmonitor.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Netmonitor' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1949180 - [devtools] Prevent showing slow loading panel if we already moved to another panel.

The call to selectSingleNode has been delayed in bug 1943543 to be done after the full loading
of the panel in order to prevent glitches and reflows while the panel is loading.

But this highlight that we should be cautious about the async loadTool step
and bail out if we already moved to another panel.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1943543

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d409daae0d6
[devtools] Prevent showing slow loading panel if we already moved to another panel. r=nchevobbe,devtools-reviewers

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5d409daae0d6