Closed
Bug 1949197
Opened 1 year ago
Closed 1 year ago
Remove feature-screendetection dependency from recently closed
Categories
(Firefox for Android :: Privacy, defect, P1)
Tracking
()
RESOLVED
FIXED
137 Branch
| Tracking | Status | |
|---|---|---|
| firefox135 | --- | unaffected |
| firefox136 | --- | fixed |
| firefox137 | --- | fixed |
People
(Reporter: mcarare, Assigned: mcarare)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-beta+
|
Details | Review |
This was added by mistake, the main purpose of having a separate module was to not request additional permission without actually implementing the feature.
Updated•1 year ago
|
status-firefox135:
--- → unaffected
status-firefox136:
--- → affected
status-firefox137:
--- → affected
| Assignee | ||
Comment 1•1 year ago
|
||
Comment 2•1 year ago
|
||
:mcarare when you land this, please add a beta uplift request on this to save some time.
It could make the final beta build of 136.0b9
Pushed by mcarare@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a3832e1873d
Remove feature-screendetection dependency from recently closed feature. r=android-reviewers,rebecatudor273
| Assignee | ||
Comment 4•1 year ago
|
||
Comment on attachment 9467132 [details]
Bug 1949197 - Remove feature-screendetection dependency from recently closed feature.
Beta/Release Uplift Approval Request
- User impact if declined/Reason for urgency: Unnecessary permissions added to app manifest.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The change only removes a dependency that was not used.
- String changes made/needed:
- Is Android affected?: Yes
Attachment #9467132 -
Flags: approval-mozilla-beta?
Comment 5•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
Comment 6•11 months ago
|
||
Comment on attachment 9467132 [details]
Bug 1949197 - Remove feature-screendetection dependency from recently closed feature.
Approved for 136.0b9
Attachment #9467132 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•11 months ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•