1949341 - Page/Video stutter with Bug 1946657 fix

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Sotaro Ikeda [:sotaro]]

Created from Bug 1946657 comment 10.

Comment 1

[Sotaro Ikeda [:sotaro]]

The fix has some workaround for the stutter, but it was not enough. Need to add more workaround.

Comment 2

[Sotaro Ikeda [:sotaro]]

But there is a lot of stutter https://uditmahajan.com/ : https://share.firefox.dev/42ZrAVn

With the STR, re-creating DCSurfaceVideo happened often. And long wait seemed to happen only during handling first present in DCSurfaceVideo::PresentVideo().

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1946657

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1949341 - Change presentDurationMs as to include first present wait duration

Comment 5

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/jobs?repo=try&revision=78540abef958604c83fd226215fcf5f0cb42d355

Comment 6

[Sotaro Ikeda [:sotaro]]

Mayank Bansal, can you check if the patch addressed the problem for you?

Comment 7

[Mayank Bansal]

I will be able to test Earliest on Tuesday morning.

Comment 8

[Sotaro Ikeda [:sotaro]]

(In reply to Mayank Bansal from comment #7)

I will be able to test Earliest on Tuesday morning.

OK, thank you.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/402be0380fdb
Change presentDurationMs as to include first present wait duration r=gfx-reviewers,lsalzman

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/402be0380fdb

Comment 11

[Mayank Bansal]

This is what i get with Nightly: https://share.firefox.dev/41u3H7b
I also very quickly (after 1-2 scrolls) get this in gfx-log: GP+[GFX1-]: Video swapchain present is slow

So in summary: On the first scroll, there is a small stutter. Then i guess the "slow swapchain" mechansim kicks-in and scrolling becomes smooth.

I dont know how significant this is. Ni? you in case you have any thought.