1949401 - Active Tabs should remain active for collapsed Tab groups

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement, P2)

Description

[Rares Doghi, Desktop QA]

Found in

• 137.0a1 (2025-02-20)

Affected versions

• 137.0a1 (2025-02-20)

Affected platforms

• all

Preconditions

• NA

Steps to reproduce

1. Create a Tab group.
2. Select any Tab from the Tab group.
3. Collapse the Tab group.

Expected result

• The Active tab should still be displayed.
  An indicator showing that the Active Tab is inside that Tab group is also needed for when we have a lot of collapsed tab groups.

Actual result

• The Moment we collapse a tab group it will jump to either a new tab or a different available tab.
  Some users would collapse the tab group instead of scrolling in order to see more tabs, but they wouldnt want to switch the active tab from the page they were on. Jumping to a different active tab without users input might not be ideal when they simply collapse the Tab group.

Regression range
Not a Regression

Comment 1

[Stephen Thompson [:sthompson]]

Notes about what we need to change/preserve when doing this work:

1. Add a third state for tab groups (“semi-collapsed”) to control styling (horizontal and vertical)
2. Keep track of group tab count to display overflow indicator (horizontal and vertical)
3. Ensure active tab is not considered hidden when in a collapsed group
4. Ensure active tab is in aria focus order when in a collapsed group
5. List all tabs menu should display the active tab even if it’s in a collapsed group
6. Ensure a semi-collapsed group displays correctly when restoring a session
7. Ensure we blur correctly when closing the active tab in a collapsed group
8. Ensure we transition to open/collapsed/semicollapsed correctly when closing the active tab in a collapsed group

Comment 2

[DJ (:dwalker)]

Attachment: Bug 1949401 - maintain visibility of selected tab when group is collapsed. r?sthompson,jswinarton

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ae9aac93b8d8
https://hg.mozilla.org/integration/autoland/rev/060a6fba17f5
maintain visibility of selected tab when group is collapsed. r=sthompson,desktop-theme-reviewers,tabbrowser-reviewers,fxview-reviewers,urlbar-reviewers,dao

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/060a6fba17f5

Comment 5

[Rares Doghi, Desktop QA]

This is so cool, how it also shows the number of tabs in that group.. This issue is verified as fixed in our latest Nightly build 142.0a1 (2025-07-03). Love this upgrade to Tab groups.

Comment 6

[Rares Doghi, Desktop QA]

Attachment: DragTab.mp4

Can someone take a look at this issue, I think this fix is causing it.
When we try to move tabs with the Vertical Sidebar the Tabs are no longer displayed underneath the actual mouse cursor and I think it happens because of the extra +nr of tabs from the collapsed groups, I also noticed that not all of them will show that number, it usually enables if we collapse a group with an active tab in it. Please take a look at the video.

Let me know if I should log a separate issue for this, also what is the correct behavior should the extra +tab nr show up for each collapsed group or not ?

Comment 7

[DJ (:dwalker)]

(In reply to Rares Doghi, Desktop QA from comment #6)

Created attachment 9498329 [details]
DragTab.mp4

Can someone take a look at this issue, I think this fix is causing it.
When we try to move tabs with the Vertical Sidebar the Tabs are no longer displayed underneath the actual mouse cursor and I think it happens because of the extra +nr of tabs from the collapsed groups, I also noticed that not all of them will show that number, it usually enables if we collapse a group with an active tab in it. Please take a look at the video.

Let me know if I should log a separate issue for this, also what is the correct behavior should the extra +tab nr show up for each collapsed group or not ?

I just filed bug 1975486 to address this. The overflow counter should not display at all if the group doesn't contain the active tab, but there is a bug that occurs when switching between horizontal and vertical tabs mode.

Comment 8

[Rares Doghi, Desktop QA]

Updating the main status flag.