Closed Bug 1975486 Opened 1 year ago Closed 1 year ago

Switching in or out of vertical tabs mode causes visual errors for collapsed tab groups

Categories

(Firefox :: Tabbed Browser, defect, P1)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
142 Branch
Tracking Flags:
Tracking Status
firefox142 --- verified
firefox143 --- verified

People

(Reporter: donwalker1987, Assigned: donwalker1987)

References

Details

(Whiteboard: [fidefe-tabgrps])

Attachments

(1 file)

Bug 1975486 - ensure hasactivetab is tracked correctly when switching in and out of vertical tabs mode. r?sthompson,jswinarton
48 bytes, text/x-phabricator-request
Details | Review

STR:

  1. create a tab group with at least 2 tabs, and ensure one of them is selected
  2. turn on vertical tabs
  3. collapse the group to show the overflow counter
  4. select a non-grouped tab

expected results:

the tab group collapses completely, and only the label is visible

actual results:

the overflow counter is still displayed next to the collapsed group's label

in general, switching in or out of vertical tabs mode causes groups to no longer track whether they have the active tab correctly.

Whiteboard: [fidefe-tabgrps]
Summary: Overflow counter for collapsed tab groups should not be visible when it does not contain the active tab → Switching in or out of vertical tabs mode causes visual errors for collapsed tab groups
Pushed by dwalker@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/21cb549614f1 https://hg.mozilla.org/integration/autoland/rev/7e14c985de46 ensure hasactivetab is tracked correctly when switching in and out of vertical tabs mode. r=sthompson,tabbrowser-reviewers
QA Contact: rdoghi

https://hg.mozilla.org/mozilla-central/rev/7e14c985de46

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox142: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
QA Whiteboard: [qa-triage-done-c143/b142] [qa-verif-needed-c143/b142]
Flags: qe-verify+

This issue is verified as fixed in our latest Beta 142.0b2 as well as our latest Nightly builds 143.0a1 (2025-07-23)

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triage-done-c143/b142] [qa-verif-needed-c143/b142] → [qa-triage-done-c143/b142] [qa-verif-done-c143/b142]
status-firefox142: fixed → verified
status-firefox143: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: