1949419 - Sort groups in "Add Tab to Group" sub menu in recently used order

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement, P2)

Description

[Rares Doghi, Desktop QA]

Found in

• 137.0a1 (2025-02-20)

Affected versions

• 137.0a1 (2025-02-20)

Affected platforms

• all

Preconditions

• NA

Steps to reproduce

1. Create a few tab groups.

Expected result

• Each time a new tab group is created it should be displayed at the top of the Add Tab to Group submenu, this way a user can either add a tab to the previously created group or he can just create a New group without having to scroll all the way back up.

Actual result

• Each time a Tab group is created its added to the bottom of the Add Tab to Group submenu

Regression range
Not a Regression

Comment 1

[Dão Gottwald [:dao]]

Amy, what's your take on this?

Comment 2

[Amy Lee [:amylee] UX]

I agree, the list order should be most the most recent created groups are at the top. If the list is long and there is scrolling, it should default to always be at the top of the list.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1949419 - Sort groups in "Add Tab to Group" sub menu in recently used order. r?dwalker,jswinarton

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1593db2777b7
Sort groups in "Add Tab to Group" sub menu in recently used order. r=dwalker,tabbrowser-reviewers

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/1593db2777b7

Comment 6

[Rares Doghi, Desktop QA]

Attachment: RecentlyCreated.mp4

Hi @Dao, can you take a look at the screen recording there seems to be some discrepancy, The Recently created Groups are not always displayed at the top, sometimes they are displayed a little lower in the list.

Comment 7

[Dão Gottwald [:dao]]

Yes, for the sake of simplicity, the sorting is now based on the group's last used time, which is derived from the group's tabs. So if you create a group from a tab that you haven't selected in a while, that group won't be at the top of the list. If you don't mind filing a new bug, we can look into making this a bit smarter for new groups, although perhaps not for 137 at this point.

Comment 8

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly build 137.0a1 (2025-02-24) , also added Bug 1950298 for Dao's suggestion.