1949433 - [Win][HCM] Declaration checkbox toggle not visible with Windows Desert contrast theme and Firefox Dark theme

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P3)

Description

[Calixte Denizet (:calixte)]

It's a really annoying bug.

Comment 1

[Calixte Denizet (:calixte)]

Attachment: image.png

The root cause of the problem is having enabled the Dark theme from the Themes setting in about:addons.
If I disable it then everything is fine.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Setting the Dark theme in about:addon makes the panel get the theme-dark class, which is used in different place in the codebase (here, for setting the stroke color of the checkbox, and since it's set to a light color because of theme-dark, it's not visible against the light background we get from the Desert theme)

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

We get the "dark" theme from https://searchfox.org/mozilla-release/rev/201ece97e589a880d0b3f000affc9bf459e90cee/devtools/client/shared/theme.js#15

return Services.appinfo.chromeColorSchemeIsDark ? "dark" : "light";

Here, in Desert HCM with Firefox dark theme selected, Services.appinfo.chromeColorSchemeIsDark is true

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

It looks like this was fixed by Bug 1988635
Calixte, could you check on latest central if that works for you to?

Comment 5

[Calixte Denizet (:calixte)]

Yep it wfm.