1949528 - URL color formatting disappears when adjusting window

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Yazan Al Macki [:yazan]]

Attachment: Screen Recording 2025-02-20 at 1.00.49 PM.mov

The address bar's greyed out URL formatting disappears when maximizing the window, it also occurs when hovering over the menu bar at the top of the screen (MacOS).

Found in Nightly version 137.0a1 (2025-02-20).

Comment 1

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Mozregression results:

• last good: 2024-04-10
• first bad: 2024-04-11
• pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4e5967329fdd11900812e37e282706d5bd223a00&tochange=6156ce2073de13dbea579f024302366622fc15b3

Only been able to reproduce this issue on macOS 14 so far.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Based on comment #1, this bug contains a bisection range found by mozregression. However, the Regressed by field is still not filled.

:alexical and :emilio, since you are the authors of the changes in the range, if possible, could you fill the Regressed by field and investigate this regression?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

This happens on linux as well if I do:

gUrlBar.textbox.style.translate = "0"

from the browser console.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

For comment 3 I get: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=888fce724359a5717cdf7d26012c386e284c6c80&tochange=8d6489d11015a4082f0fba9dc88b3b1ed309e2a1

Comment 5

[Emilio Cobos Álvarez (:emilio)]

       #urlbar:not([unifiedsearchbutton-available]) > .urlbar-input-container > & {
         /* Display as off-screen to get focus */
         position: fixed;
         top: -999px;
       }

Yeah that'd cause a reframe when the urlbar gets a transform...

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1949528 - Avoid reframing the toolbox when going into macOS full-screen. r=#theme

So that the urlbar highlighting doesn't get lost. This is kind of a
workaround tbh but it's not too bad so...

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10f0e707cd24
Avoid reframing the toolbox when going into macOS full-screen. r=desktop-theme-reviewers,dao

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1937363

Comment 9

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/10f0e707cd24

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox136 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

We're late enough in the cycle and the system theme is off on release, so I don't think it makes sense to uplift this one. Might be worth uplifting bug 1949742 tho.