Closed Bug 1949742 Opened 5 days ago Closed 5 days ago

Use will-change: transform in the urlbar to make sure to consistently contain fixed position descendants.

Categories

(Firefox :: Address Bar, task)

Desktop
macOS
task

Tracking

()

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- verified

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

No description provided.

To make sure to consistently contain fixed position descendants.

This fixes the menubar case in bug 1949528 comment 5, which was
regressed by bug 1937363 because it added a position: fixed element
inside the urlbar.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b401d9edda8d Use will-change in the urlbar. r=desktop-theme-reviewers,urlbar-reviewers,dao
Status: NEW → RESOLVED
Closed: 5 days ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch

Comment on attachment 9467658 [details]
Bug 1949742 - Use will-change in the urlbar. r=#theme,#urlbar-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: See bug 1949528
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: On macOS, go fullscreen and hover over the menubar.
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): trivial css fix
  • String changes made/needed: none
  • Is Android affected?: No
Attachment #9467658 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9467658 [details]
Bug 1949742 - Use will-change in the urlbar. r=#theme,#urlbar-reviewers

Fx136 is now in release.
Moving uplift request from beta to release for possible inclusion in an RC respin or later dot release.

Attachment #9467658 - Flags: approval-mozilla-beta? → approval-mozilla-release?
QA Whiteboard: [qa-triaged]

I can reproduce this issue in Nightly v135.0a1 (2025-01-06) and Nightly v137.0a1 (2025-02-20) and I can verify the fix in Nightly v137.0a1 (2025-02-24) and Nightly v137.0a1 (2025-02-25). Testing was performed on MacOS 11 and MacOS 14 aarch64.

Will keep an eye for a possible uplift for verification.

OS: Unspecified → macOS
Hardware: Unspecified → Desktop
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: