1949742 - Use will-change: transform in the urlbar to make sure to consistently contain fixed position descendants.

Status: VERIFIED FIXED

(Firefox :: Address Bar, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1949742 - Use will-change in the urlbar. r=#theme,#urlbar-reviewers

To make sure to consistently contain fixed position descendants.

This fixes the menubar case in bug 1949528 comment 5, which was
regressed by bug 1937363 because it added a position: fixed element
inside the urlbar.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b401d9edda8d
Use will-change in the urlbar. r=desktop-theme-reviewers,urlbar-reviewers,dao

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b401d9edda8d

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9467658 [details]
Bug 1949742 - Use will-change in the urlbar. r=#theme,#urlbar-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: See bug 1949528
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: On macOS, go fullscreen and hover over the menubar.
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial css fix
• String changes made/needed: none
• Is Android affected?: No

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9467658 [details]
Bug 1949742 - Use will-change in the urlbar. r=#theme,#urlbar-reviewers

Fx136 is now in release.
Moving uplift request from beta to release for possible inclusion in an RC respin or later dot release.

Comment 6

[Daniel Bodea [:danibodea]]

I can reproduce this issue in Nightly v135.0a1 (2025-01-06) and Nightly v137.0a1 (2025-02-20) and I can verify the fix in Nightly v137.0a1 (2025-02-24) and Nightly v137.0a1 (2025-02-25). Testing was performed on MacOS 11 and MacOS 14 aarch64.

Will keep an eye for a possible uplift for verification.

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9467658 [details]
Bug 1949742 - Use will-change in the urlbar. r=#theme,#urlbar-reviewers

Approved for 136.0 RC3

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/f5ee9453f02a

Comment 9

[Daniel Bodea [:danibodea]]

I can also confirm this fix in RC 136.0 build3. Being in fullscreen and hovering over the menubar no longer disabled the formatting of the URL in the addressbar. Tested in MacOS 11 and MacOS 14 aarch64. Closing report.