Use the category manager for browser-ui-startup invocations instead of doing it manually from BrowserGlue
Categories
(Firefox :: General, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox138 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Keywords: perf-alert)
Attachments
(1 file)
This is a continuation of the work that Gijs started in bug 1896783 and bug 1880904, where we move some of the module initialization for things on browser-ui-startup out from the BrowserGlue dumping ground into BrowserComponents.manifest via the category manager.
|
Assignee | |
Comment 1•1 month ago
|
||
|
||
Comment 2•1 month ago
|
||
The Bugbug bot thinks this bug should belong to the 'Fenix::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
|
||
Updated•1 month ago
|
|
||
Comment 4•23 days ago
|
||
| bugherder | ||
|
||
Comment 5•9 days ago
|
||
(In reply to Pulsebot from comment #3)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f426167fc251
Use the category manager for before-ui-startup invocations.
r=Gijs,firefox-desktop-core-reviewers
Perfherder has detected a browsertime performance change from push f426167fc251be278ac2768d7604a32e468d78cc.
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) | Performance Profiles |
|---|---|---|---|---|---|
| 12% | espn FirstVisualChange | windows11-64-24h2-shippable | fission warm webrender | 117.40 -> 103.48 | Before/After |
| 6% | espn largestContentfulPaint | windows11-64-24h2-shippable | fission warm webrender | 83.44 -> 78.03 | Before/After |
| 6% | twitter fcp | windows11-64-24h2-shippable | bytecode-cached cold fission webrender | 52.42 -> 49.09 | Before/After |
| 2% | twitter LastVisualChange | windows11-64-24h2-shippable | bytecode-cached cold fission webrender | 835.78 -> 815.66 | Before/After |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with ./mach try perf --alert 44309
For more information on performance sheriffing please see our FAQ.
Description
•