1950060 - Add Linux and macOS support for our zucchini vendoring

Status: RESOLVED FIXED

(Toolkit :: Application Update, task, P3)

Description

[Yannis Juglaret [:yannis]]

As part of bug 1632374, once we have Windows-only support for zucchini patch application and zucchini compilation after bug 1950055, we can start supporting other platforms. This will remain behind a compilation flag for the moment, because we don't want it in official builds.

Comment 1

[Yannis Juglaret [:yannis]]

Attachment: WIP: Bug 1950060 - Add Linux and macOS support for zucchini. r=bobowen

This patch adds the upstream definitions required to build and use
zucchini on Linux and macOS platforms.

Comment 2

[Yannis Juglaret [:yannis]]

Attachment: Bug 1950060 - Add Linux and macOS support for zucchini. r=bobowen!,#firefox-build-system-reviewers!

This patch adds the upstream definitions required to build and use
zucchini on Linux and macOS platforms.

Comment 3

[Yannis Juglaret [:yannis]]

Attachment: Bug 1950060 - Enable zucchini support in the updater. r=#application-update-reviewers!,#firefox-build-system-reviewers!

This patch makes our updater support zucchini patches if present in a
mar file. This does not mean that we need to start shipping zucchini
patches right now. bspatch support is preserved and the updater is able
to consume both kinds of patches.

This will let us benchmark zucchini patch application in updater.exe,
and experiment with zucchini rollouts that target a small portion of the
population so we can catch any issue ahead of a global rollout.

This patch also adds the zucchini equivalents for our tests that use a
bspatch-based mar.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5e0b5fafef5e
https://hg.mozilla.org/integration/autoland/rev/cd61e2ca04dc
Add Linux and macOS support for zucchini. r=bobowen,firefox-build-system-reviewers,glandium
https://github.com/mozilla-firefox/firefox/commit/a3cd4c7b93a5
https://hg.mozilla.org/integration/autoland/rev/c0ccc048a791
Enable zucchini support in the updater. r=application-update-reviewers,firefox-build-system-reviewers,bytesized,glandium

Comment 5

[Serban Stanca [:SerbanS]]

Reverted this because it was causing zucchini related build bustages.

• Revert link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/third_party/zucchini/chromium/base/files/file_posix.cc:60:5: error: unused function 'CallFutimes' [-Werror,-Wunused-function]

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/81ed1eb72fc3
https://hg.mozilla.org/integration/autoland/rev/404e9279c28a
Add Linux and macOS support for zucchini. r=bobowen,firefox-build-system-reviewers,glandium
https://github.com/mozilla-firefox/firefox/commit/a714df5cd9fc
https://hg.mozilla.org/integration/autoland/rev/c658e5593deb
Enable zucchini support in the updater. r=application-update-reviewers,firefox-build-system-reviewers,bytesized,glandium

Comment 7

[[e-mail]]

https://hg.mozilla.org/mozilla-central/rev/404e9279c28a
https://hg.mozilla.org/mozilla-central/rev/c658e5593deb

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/404e9279c28a
https://hg.mozilla.org/mozilla-central/rev/c658e5593deb

Comment 9

[Yannis Juglaret [:yannis]]

Attachment: Bug 1950060 - Add Linux and macOS support for zucchini.

This patch adds the upstream definitions required to build and use
zucchini on Linux and macOS platforms. We also remove zucchini support
in mingwclang builds (32-bit and 64-bit) because of the lack of SEH
support in the 32-bit compiler (bug 1975960).

Original Revision: https://phabricator.services.mozilla.com/D253663

Comment 10

[Yannis Juglaret [:yannis]]

Attachment: Bug 1950060 - Enable zucchini support in the updater.

This patch makes our updater support zucchini patches if present in a
mar file. This does not mean that we need to start shipping zucchini
patches right now. bspatch support is preserved and the updater is able
to consume both kinds of patches.

This will let us benchmark zucchini patch application in updater.exe,
and experiment with zucchini rollouts that target a small portion of the
population so we can catch any issue ahead of a global rollout.

This patch also adds the zucchini equivalents for our tests that use a
bspatch-based mar.

Original Revision: https://phabricator.services.mozilla.com/D253687

Comment 11

[Dianna Smith [:diannaS]]

Copied from bug 1987589

firefox-esr140 Uplift Approval Request

• User impact if declined: Uplifting zucchini support to ESR140 will ensure that users can apply partial updates to ESR153 in July 2026, given that these partial updates will most likely be released as zucchini-based MAR files.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: The uplifted code will mostly be dead code for the lifetime of ESR140. It will only get used once we start shipping ESR153 in July 2026. By this time we will have a better idea of the trust level we can place in zucchini support, that will help inform our decision whether to use zucchini-based partials for the ESR140 to ESR153 update.
• String changes made/needed: No
• Is Android affected?: no

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/1b6830ff11bc
https://hg.mozilla.org/releases/mozilla-esr140/rev/f7610b4c389e