1976038 - Make zucchini partial generation use our in-tree built zucchini executable

Status: RESOLVED FIXED

(Release Engineering :: General, task)

Description

[Yannis Juglaret [:yannis]]

In bug 1919654, we landed a partials-zucchini task that generates partials by building and using the zucchini binary from upstream chromium. After the landing of bug 1950060 we will have our own binary generated from an in-tree vendoring. For compatibility reasons, partials-zucchini should use this binary rather than the one from upstream if possible.

Possible reasons for incompatibility include:

• desynchronization between the versions of Zucchini used by partials-zucchini and our in-tree vendoring;
• different choices in supported features, for example our in-tree vendoring will not support DEX because we don't plan to ship Android-related files as part of our updates, so if somehow (admittedly that is very unlikely) we were to generate a partial that contains a patch for a Dalvik executable, the patch generated by partials-zucchini would be unprocessable by updater.exe.

Comment 1

[Yannis Juglaret [:yannis]]

Attachment: Bug 1976038 - Add a build project for the standalone zucchini binary. r=#firefox-build-system-reviewers!

This lets us build the standalone zucchini binary without building all
Firefox, by using a mozconfig file containing:

ac_add_options --enable-project="tools/zucchini"

Comment 2

[Yannis Juglaret [:yannis]]

Attachment: Bug 1976038 - Update linux64-zucchini-bin jobs to build from our own source tree. r=hneiva

We stop relying on the chromium build system and tools, and instead
build the standalone zucchini binary directly from our own source tree.
This uses the tools/zucchini build project, to avoid having to build all
Firefox.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/33610f84b07d
https://hg.mozilla.org/integration/autoland/rev/e28ed0d2d4c8
Add a build project for the standalone zucchini binary. r=firefox-build-system-reviewers,sergesanspaille
https://github.com/mozilla-firefox/firefox/commit/63ed6d500144
https://hg.mozilla.org/integration/autoland/rev/04d56c52a6a5
Update linux64-zucchini-bin jobs to build from our own source tree. r=hneiva

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e28ed0d2d4c8
https://hg.mozilla.org/mozilla-central/rev/04d56c52a6a5