1950836 - Enable Import Attributes in 138 release

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

The feature "Import Attributes" has been landed for a while, and the spec has been merged into ecma262 spec https://github.com/tc39/ecma262/pull/3057 recently.
I plan to enable it in Nightly in 138 release. https://whattrainisitnow.com/release/?version=138

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1950836 - Enable import.attributes by default.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1950836 - Remove the pref in ini files.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4da337806c5d
Enable import.attributes by default. r=jonco,dminor
https://hg.mozilla.org/integration/autoland/rev/42e4bb6a1d09
Remove the pref in ini files. r=jonco,dminor

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4da337806c5d
https://hg.mozilla.org/mozilla-central/rev/42e4bb6a1d09

Comment 5

[Tom Schuster]

Please request a release note, thank you!

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Release Note Request (optional, but appreciated)
[Why is this notable]: This is a Javascript feature that allows JS to instruct the JS engine how a module should be loaded.
[Affects Firefox for Android]: Yes
[Suggested wording]: Import Attributes.
[Links (documentation, blog post, etc)]:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import/with

Comment 7

[Dianna Smith [:diannaS]]

Added to the 138 nightly release notes and on track to be in the final release notes.

Comment 9

[Dipika]

I'm updating the docs on MDN. I tested this in Nightly and it looks like only with { type: "json" } is currently enabled.
with { type: "css" } still throws an "invalid module type" error. Could you please confirm?
It'll help me update the browser compat table accurately. Thanks!

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Dipika from comment #9)

I'm updating the docs on MDN. I tested this in Nightly and it looks like only with { type: "json" } is currently enabled.
with { type: "css" } still throws an "invalid module type" error. Could you please confirm?
It'll help me update the browser compat table accurately. Thanks!

That's correct, "JSON modules" are supported, whereas "CSS modules" aren't. (bug 1720570)

Comment 11

[Dipika]

I've updated MDN docs (browser compat and release notes) for this feature.
The work can be tracked in https://github.com/mdn/content/issues/38878.

Thanks Yoshi for your timely help!