1950909 - [composable toolbar] Initial integration in Fenix

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

Need an initial integration of the composable toolbar to serve as a base for the future configuration work.

The new toolbar should be gated by a hardcoded feature flag making it only available only in debug for the moment.
To limit the availability to only developers working on this feature the flag should be a secret setting only available in debug builds.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1950909 - part 1 - Add a new secret settings for enabling the redesigned toolbar r=#android-reviewers

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1950909 - part 1 - Add a new secret settings for enabling the composable toolbar r=#android-reviewers

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1950909 - part 2 - Use a generic toolbar in Fenix instead of the BrowserToolbar view r=#android-reviewers

This will allow to easily change between a toolbar view and a toolbar composable.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1950909 - part 3 - Refactor the toolbar menu builder out of BrowserToolbarView r=#android-reviewers

This will make the toolbar menu building be reusable and allow decoupling
other functionalities from the browser toolbar view.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1950909 - part 4 - Conditionally use a composable toolbar while browsing r=#android-reviewers

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1950909 - part 5 - Setup dynamic scrolling for the composable toolbar r=#android-reviewers

Being able to replace the toolbar view with a toolbar composable means we
can also make use of the existing support for the dynamic toolbar behavior.

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1950909 - part 6 - Use a generic toolbar on Fenix homescreen r=#android-reviewers

This will allow to easily change between a toolbar view and a toolbar composable.

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1950909 - part 7 - Move home toolbar related classes to the toolbar package r=#android-reviewers

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1950909 - part 8 - Conditionally use a composable toolbar on home r=#android-reviewers

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4af06bb3a8ae
part 1 - Add a new secret settings for enabling the composable toolbar r=android-reviewers,skhan
https://hg.mozilla.org/integration/autoland/rev/2646fe0c5d04
part 2 - Use a generic toolbar in Fenix instead of the BrowserToolbar view r=android-reviewers,tchoh
https://hg.mozilla.org/integration/autoland/rev/cc9b00c0d952
part 3 - Refactor the toolbar menu builder out of BrowserToolbarView r=android-reviewers,tchoh
https://hg.mozilla.org/integration/autoland/rev/c56ea18206fa
part 4 - Conditionally use a composable toolbar while browsing r=android-reviewers,tchoh
https://hg.mozilla.org/integration/autoland/rev/b1e3b80b26db
part 5 - Setup dynamic scrolling for the composable toolbar r=android-reviewers,tchoh
https://hg.mozilla.org/integration/autoland/rev/1983877ca95d
part 6 - Use a generic toolbar on Fenix homescreen r=android-reviewers,tchoh
https://hg.mozilla.org/integration/autoland/rev/bf9f87000bef
part 7 - Move home toolbar related classes to the toolbar package r=android-reviewers,tchoh
https://hg.mozilla.org/integration/autoland/rev/56105c4cfe3d
part 8 - Conditionally use a composable toolbar on home r=android-reviewers,tchoh

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4af06bb3a8ae
https://hg.mozilla.org/mozilla-central/rev/2646fe0c5d04
https://hg.mozilla.org/mozilla-central/rev/cc9b00c0d952
https://hg.mozilla.org/mozilla-central/rev/c56ea18206fa
https://hg.mozilla.org/mozilla-central/rev/b1e3b80b26db
https://hg.mozilla.org/mozilla-central/rev/1983877ca95d
https://hg.mozilla.org/mozilla-central/rev/bf9f87000bef
https://hg.mozilla.org/mozilla-central/rev/56105c4cfe3d