1950911 - Test warning when running test browser/base/content/test/popups/browser_popup_resize.js after bug 581863

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

STR:
Run ./mach test browser/base/content/test/popups/browser_popup_resize.js on Linux

I get these warnings:

0:13.13 INFO Console message: [JavaScript Error: "ReferenceError: AppConstants is not defined" {file: "chrome://mochitests/content/browser/browser/base/content/test/popups/head.js" line: 131}]
resizeListener@chrome://mochitests/content/browser/browser/base/content/test/popups/head.js:131:7
EventListener.handleEvent*testPropertyDeltas@chrome://mochitests/content/browser/browser/base/content/test/popups/head.js:158:7
execute@resource://testing-common/SpecialPowersSandbox.sys.mjs:139:12
_spawnTask@resource://testing-common/SpecialPowersChild.sys.mjs:1620:15
receiveMessage@resource://testing-common/SpecialPowersChild.sys.mjs:255:21
JSActor query*receiveMessage@resource://testing-common/SpecialPowersParent.sys.mjs:1384:14
JSActor query*spawn@resource://testing-common/SpecialPowersChild.sys.mjs:1549:17
run@chrome://mochitests/content/browser/browser/base/content/test/popups/head.js:351:25
ResizeMoveTest/<@chrome://mochitests/content/browser/browser/base/content/test/popups/head.js:326:18
async*handleTask@chrome://mochikit/content/browser-test.js:1170:26
_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1242:18
async*Tester_execTest@chrome://mochikit/content/browser-test.js:1383:14
nextTest/<@chrome://mochikit/content/browser-test.js:1159:14
SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13

because AppConstants isn't defined in:
https://searchfox.org/mozilla-central/rev/80ae03d93e3fd5769b16f37719b610e359f8fc62/browser/base/content/test/popups/head.js#130

Strangely this doesn't fail the test?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 581863

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Yeah so that is because that function runs in a content task, so we need to import AppConstants.

Indeed, rather weird it doesn't fail the test. Gijs do you know why that might be? Do we have a bug on file to track exceptions in ContentTasks failing mochitests or something?

Comment 3

[:Gijs (he/him)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Yeah so that is because that function runs in a content task, so we need to import AppConstants.

Indeed, rather weird it doesn't fail the test. Gijs do you know why that might be? Do we have a bug on file to track exceptions in ContentTasks failing mochitests or something?

You mean SpecialPowers.spawn, right? ContentTasks are deprecated.

So, https://searchfox.org/mozilla-central/rev/4bacdbc8ac088f2ee516daf42c535fab2bc24a04/testing/specialpowers/content/SpecialPowersParent.sys.mjs#1383-1392 looks to me like it would reject and the caller would get the promise rejection and that would normally fail the test.

But the error here is not throwing an exception in the spawned run, it's throwing one in an event listener. I guess it's not getting picked up by the uncaught error/rejection stuff as that runs in the parent process.

There are bugs on file to make any errors reported to console fail mochitests (also stuff from try...catch() { console.error }), e.g. bug 1687998, but they do not currently do that.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1950911 - Remove test workaround. r=julienw,stransky,Gijs

This issue got fixed by bug 1946184, and the test passes now with the
stricter version of the check.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

https://treeherder.mozilla.org/jobs?repo=try&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Csuccess%2Cretry%2Cusercancel%2Crunning%2Cpending%2Crunnable&tier=1%2C2%2C3&revision=e43d7ade638f64cea54e3d8adf397f9c453fbfa7

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8e8c5628e8b
Remove test workaround. r=Gijs

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/a8e8c5628e8b