1951284 - Address bar is transparent when pasting text into new window

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Gregory Pappas [:gregp]]

Attachment: bug.webm

Steps to reproduce:

1. Open a new window with keyboard shortcut (Ctrl+N/Cmd+N)
2. Quickly paste text with keyboard shortcut (Ctrl+V/Cmd+V)

Actual results:
Sometimes, the address bar is transparent

Expected results:
The address bar has a background color

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1927111, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1951284 - Fix a race condition in UrlbarInput.startLayoutExtend(). r=#urlbar-reviewers

hasAttribute("breakout") isn't the right check for "do we support
breakout", since we might be in the middle of recomputing the breakout
dimensions (which removes the attribute temporarily).

Use this.#allowBreakout instead.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1927111

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d83af8f6e07f
Fix a race condition in UrlbarInput.startLayoutExtend(). r=urlbar-reviewers,jteow

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d83af8f6e07f

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox137 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9469326 [details]
Bug 1951284 - Fix a race condition in UrlbarInput.startLayoutExtend(). r=#urlbar-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One liner.
• String changes made/needed: none
• Is Android affected?: No

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9469326 [details]
Bug 1951284 - Fix a race condition in UrlbarInput.startLayoutExtend(). r=#urlbar-reviewers

-> 137 beta 3, thanks.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ed2c82d61595

Comment 10

[Bogdan Maris, Desktop Test Engineering]

Reproduced the issue described in comment 0 using an old Nightly build before the fix (2025-03-02), verified that using latest Nightly 138.0a1 and latest Firefox 137 beta build (from treeherder) this is indeed fixed across platforms (macOS 13.7, Ubuntu 22.04 and Windows 11).