1951466 - Predictive connections don't update partitionKey and are stored as unpartitioned cache entries

Status: RESOLVED WORKSFORME

(Core :: Networking: Cache, defect, P2)

Description

[Manuel Bucher [:manuel]]

See https://phabricator.services.mozilla.com/D239760?id=991058 and Bug 1950058 for other investigation. Splitting this part off from the other patch to land smaller of work chunks faster. This also has the potential to break other tests.

Comment 1

[Manuel Bucher [:manuel]]

Attachment: Bug 1951466 - Fix partitionKey for predictive connections r=#necko

Comment 2

[Manuel Bucher [:manuel]]

Note to self: pernosco - netwerk/test/unit/test_predictor.js unexpected speculative connection
(for current test failure: FAIL test_pageload - [test_pageload : 114] Got preconnect for unexpected uri http://localhost:4444 - false == true)

Comment 3

[Manuel Bucher [:manuel]]

investigate why no preconnect is made: https://pernos.co/debug/CcIC7NyTr6zptmeSuxseFA/index.html

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc1aed840c6c
Fix partitionKey for predictive connections r=necko-reviewers,kershaw

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser/browser_sanitize.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/originattributes/test/browser/browser_sanitize.js | https://example.net/ should not be cached for all origin attributes.0 - Got false, expected true

Please also check these mochitests failures. Failure log: https://treeherder.mozilla.org/logviewer?job_id=500207864&repo=autoland

Comment 6

[Manuel Bucher [:manuel]]

Failing tests (that need to be taken care of):

• toolkit/components/antitracking/test/browser/browser_referrerDefaultPolicy.js: Bug 1899785, Bug 1899785

  We sent the correct Referer header - Got "", expected "http://example.net/"
  [...]

• browser/components/originattributes/test/browser/browser_sanitize.js: Bug 1905896

  https://example.net/ should not be cached for all origin attributes.0 - Got false, expected true
  [...]

Comment 7

[Manuel Bucher [:manuel]]

Not blocking bfcache. wpt-test are passing. Still a item to be addressed.

Comment 8

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:manuel, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 9

[Manuel Bucher [:manuel]]

Failing some test cases (which likely need updating). Can't land.

Comment 10

[Valentin Gosu [:valentin]]

We removed the predictor in bug 2006028.