1951824 - Exchange AutoDiscover: Fix code to show username field

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Ben Bucksch (:BenB)]

(Re-filing the confusing bug 1907443)

In account setup, with Exchange AutoDiscover, we show a username field, but only when necessary, that is, when the server returns a HTTP 401.

That old code is racy. Only by coincidence, in TB 128, that race does not actually happen, because the new OAuth2 prompt during AutoDiscover waits for user input and blocked the racing function.

This is a fix that makes this code cleaner, more reliable, and not racy anymore.

Comment 1

[Ben Bucksch (:BenB)]

Fix: All of https://phabricator.services.mozilla.com/D216824 , apart from the last hunk. We will re-attach it here as minimal patch.

Comment 2

[Ben Bucksch (:BenB)]

Attachment: Bug 1951824 - Exchange AutoDiscover: Fix code to show username field. r=neil

In account setup, with Exchange AutoDiscover, we show a username field, but only when necessary, that is, when the server returns a HTTP 401. That old code is racy. Only by coincidence, in TB 128, that race does not actually happen, because the new OAuth2 prompt during AutoDiscover waits for user input and blocked the racing function.

This is a fix that makes this code cleaner, more reliable, not racy anymore, and also more readable.

Comment 3

[Ben Bucksch (:BenB)]

Attachment: Bug 1951824 - Exchange AutoDiscover: Fix code to show username field. r=neil

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/44891cb19390
Exchange AutoDiscover: Fix code to show username field. r=Neil,babolivier,vineet