1951907 - [Downloads v2] Add and use localised size formatting for downloads

Status: VERIFIED FIXED

(Firefox for Android :: Downloads, enhancement, P2)

Description

[Rahul Sainani [:rsainani]]

Currently, the formatting for download file sizes only formats in English, and dooesn't take into account any other file size units except KB and MB. The task is to use a formatter from the android platform or stdlib that follow the general spec.

Comment 1

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1951907 - Use Formatter library for localized size formatting for downloads

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9efd3b97636b
Use Formatter library for localized size formatting for downloads r=android-reviewers,rsainani

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9efd3b97636b

Comment 4

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Hey QA,
Can you please verify that download file sizes can now show in MB, kB, and GB? Previously, we could only display them in MB and kB. Similarly, can we please verify that these units get localized. For example, in French, MB should be localized to Mo, etc.... The places that come to mind to check for these (localized) units is the Downloads screen and the download dialog prompt before and after downloads. Please feel free to check other places if they come to mind. Note that translations was out of the scope of this ticket, so please ignore the file sizes displayed when downloading translations packs.

A website that can be used for testing download sizes is: http://xcal1.vodafone.co.uk/

Comment 5

[Mira Lobontiu (Android QA)]

Attachment: 1951907.png

Verified as implemented on the latest Fenix Nightly 138.0a1 from 3/20 using a Google Pixel 6 (Android 15), and a Samsung Galaxy A14 (Android 14).