1958905 - Investigate how to use fakes with test fixtures

Status: RESOLVED FIXED

(Firefox for Android :: General, task)

Description

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Currently, we need to create a FakeFileSizeFormatter file for tests that use this class in different packages. See 1, 2, 3. Ideally, we want to have this in the test package of where FileSizeFormatter lives. This does not work at the moment due to gradle dependency issues, which should be fixed with the use of test fixtures. Then, we should make 1 FakeFileSizeFormatter file / class in the test package of where FileSizeFormatter lives and use this in all of the tests

Comment 1

[Rahul Sainani [:rsainani]]

Nick, thanks for filing this. I don't think this blocked Bug 1948708

My suggestion would be to remove that.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::UI Tests' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1958905 - Consolidate FakeFileSizeFormatter with test fixtures

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4a8400a4687c
https://hg.mozilla.org/integration/autoland/rev/79883bccebbf
Consolidate FakeFileSizeFormatter with test fixtures r=android-reviewers,adhingra,giorga

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/79883bccebbf