Closed
Bug 1952054
Opened 1 year ago
Closed 1 year ago
Debugger Source Tree settings icon is off by 1 px
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(firefox137 fixed, firefox138 fixed)
RESOLVED
FIXED
138 Branch
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
Looks like I messed up something when landing Bug 1949058, there's an unexpected 1 px gap everywhere
| Assignee | ||
Comment 1•1 year ago
|
||
Remove 1px gap on the right and top of the icon
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c0b17182676
[devtools] Update position for Debugger sources settings icon r=nchevobbe,devtools-reviewers
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox138:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
| Assignee | ||
Comment 4•1 year ago
|
||
Remove 1px gap on the right and top of the icon
Original Revision: https://phabricator.services.mozilla.com/D240534
Updated•1 year ago
|
Attachment #9470402 -
Flags: approval-mozilla-beta?
Comment 5•1 year ago
|
||
beta Uplift Approval Request
- User impact if declined: small UI follow up for a bug which landed in 137
- Code covered by automated testing: no
- Fix verified in Nightly: yes
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: -
- Risk associated with taking this patch: low
- Explanation of risk level: css only change, devtools only
- String changes made/needed: none
- Is Android affected?: no
Updated•1 year ago
|
Attachment #9470402 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•1 year ago
|
status-firefox137:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•