Add condition to geo-strict review checker when feature flag is flipped
Categories
(Firefox :: Sidebar, task)
Tracking
()
People
(Reporter: sclements, Unassigned)
References
Details
I'm filing this bug for the RC team based on a discussion in today's sidebar shiproom with Rob and Ania. Once the current experiment ends on March 24th, we're going to restrict the review checker in the new sidebar to only show if a users home region is in the US. This will prevent the panel from showing in the Customize Sidebar panel for those users outside the US, and you can add a line of code here that uses the Region module, which will look like this:
if (
!PrivateBrowsingUtils.isWindowPrivate(window) &&
SidebarController.Region.home == "US"
)
But this should probably be done at the same time that browser.shopping.experience2023.integratedSidebar is set to true. And then when review-checker is added to the launcher for all users, per my patch in bug 1920489, it still won't show for users outside the US, but will make it a little future proof in terms of loosening that geo restriction in the future without having to introduce another pref branch for those additional users (because it will be added to sidebar.main.tools but filtered away in the launcher until certain conditions are met).
A question that came up during this meeting is whether other shopping prefs need to be enabled at the same time and if any need additional geo-strictions using the region module. Katherine, maybe you can help with this?
Comment 1•1 year ago
|
||
Plans here have changed, so closing this out.
Description
•