1952602 - Themes do not fully work on side bar

Status: NEW

(Firefox :: Theme, enhancement, P2)

Description

[thinkseal]

Attachment: what it looks like on firefox 136 stable and 138 nighlty

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:135.0) Gecko/20100101 Firefox/135.0

Steps to reproduce:

I installed a theme (that I had tested on Zen Browser to make sure that it had an image that would extent to the bottom of the screen if allowed) and enabled the sidebar.

Actual results:

The theme did not fully extend across the sidebar, even though it should be able to.

Expected results:

The theme image should have fully extended across the sidebar since the theme has an image that can extend that far.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[thinkseal]

The sidebar does not get themed from themes. Here is an example of what it should look like with the theme I have selected.
https://github.com/Thinkseal/test/blob/main/Screenshot%202025-03-12%20at%2016.44.23.png?raw=true
And this is what it currently looks like.
https://github.com/Thinkseal/test/blob/main/Screenshot%202025-03-12%20at%2016.46.11.png?raw=true

Comment 3

[Sam Foster [:sfoster] (he/him)]

We anticipated this issue and looked into it in bug 1893214. In summary, our documentation has long advised theme authors that they can place one or more background images behind the toolbars at the top of the browser window. We even suggest a size, typically 2000px wide and at least 200px high. The new sidebar adds a sidebar launcher - which is kind of a toolbar - below the other toolbars and on the side of the content area. Ideally we'd enable the background image to sit behind the sidebar launcher as well. But most of the existing 2000x200 size and aspect ratio theme images would not work well there. They were never designed to stretch or tile vertically. Another option would be to add the theme's background image to the sidebar so it would show up twice. That might work well for some themes and not so well for others.

The design intention was always to have a smooth seamless transition between the horizontal toolbars and the new launcher vertical toolbar. To support that I think we may have to extend the theme manifest itself and add a new property for images explicitly design to work this way.

I looked for and failed to find a bug on file for that work. Unless I just missed it, maybe this can be it?

Comment 4

[thinkseal]

The design intention was always to have a smooth seamless transition between the horizontal toolbars and the new launcher vertical toolbar. To >support that I think we may have to extend the theme manifest itself and add a new property for images explicitly design to work this way.

I looked for and failed to find a bug on file for that work. Unless I just missed it, maybe this can be it?

I would be fine with that as long as if the theme can go down all the way it can