Paint the toolbox background-color to the body element.
Categories
(Firefox :: Theme, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox149 | --- | unaffected |
| firefox150 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Regressed 1 open bug)
Details
(Keywords: perf-alert)
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
15.43 KB,
patch
|
Details | Diff | Splinter Review |
This:
- Simplifies the sidebar rendering a bit.
- Allows to guarantee full opacity in the backdrop for themes more straight-away.
- Is a pre-requisite for bug 1952602 (I initially wrote it for that bug, but I think splitting it is worth it since it's less controversial).
|
Assignee | |
Comment 1•9 months ago
|
||
Split off from bug 1952602. Main idea is to draw the toolbox background
just once, on <body>, and then the rest falls off that.
This simplifies some things, shouldn't be a meaningful behavior
change, and would be a prerequisite for bug 1952602.
|
||
Comment 3•7 months ago
|
||
| bugherder | ||
|
||
Comment 4•7 months ago
|
||
(In reply to Pulsebot from comment #2)
Pushed by ealvarez@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/6b6c35c7c814
https://hg.mozilla.org/integration/autoland/rev/8d54cc2c66e9
Paint the toolbox background-color on the <body> element.
r=desktop-theme-reviewers,extension-reviewers,tabbrowser-reviewers,sfoster,
rpl,nsharpley
Perfherder has detected a browsertime performance change from push 8d54cc2c66e9d90b6f297c017c6294c3c6b30edd.
No action is required from the author; this comment is provided for informational purposes only.
| Improvement | Test | Platform | Options | Absolute values [old vs new] | Performance Profiles |
|---|---|---|---|---|---|
| 5% | bing-search ContentfulSpeedIndex (doc) | linux1804-64-shippable-qr | cold fission webrender | 467.47 ms -> 444.78 ms | Before/After |
Need Help or Information?
If you have any questions, please reach out to afinder@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
|
|
||
Updated•7 months ago
|
|
|
Assignee | |
Comment 5•6 months ago
|
||
See comments in bug 2013682 for context.
|
||
Updated•6 months ago
|
|
||
Updated•5 months ago
|
Description
•