Open Bug 1952681 Opened 11 days ago Updated 9 days ago

Fix up content script tests that are skipped when sessionHistoryInParent

Categories

(WebExtensions :: General, task, P2)

task

Tracking

(Not tracked)

People

(Reporter: robwu, Assigned: robwu)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [addons-jira])

Attachments

(1 file)

Some content script tests are skipped with the condition sessionHistoryInParent. But SHIP is enabled by default, which means that these tests are effectively skipped on all configurations that match what users actually see.

I'm refactoring content script logic that affect timing (bug 1951688), and these tests cover relevant scenarios that are sensitive to timing.

I'm going to fix test_ext_contentscript_context.js and test_ext_contentscript_context_isolation.js and re-enable them (in xpcshell-common.toml).

While looking at the issue, I saw that test_ext_web_accessible_resources.js is also skipped when sessionHistoryInParent, and will fix that test too.

The skip-if of these tests are currently associated with bug 1762638.

Depends on: 1952682

Some tests are skipped when sessionHistoryInParent. But SHIP is enabled
by default, so effectively these tests were skipped.

Fix the underlying issues in the tests and re-enable them.
This is mostly fixing the logic so that test state between
ContentPage.spawn calls are correctly carried over.

Several location.href navigations were replaced with
contentPage.loadURL (which awaits the load) because without it, the
tests would fail when run with --disable-fission.

Severity: -- → N/A
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: