Closed Bug 1952993 Opened 8 months ago Closed 8 months ago

test_top_sites.js should not import any modules from newtab

Categories

(Firefox :: Top Sites, task, P1)

Product:
Firefox
Component:
Top Sites
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
138 Branch
Tracking Flags:
Tracking Status
firefox138 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

(Whiteboard: [hnt-trainhop])

Attachments

(1 file)

Bug 1952993 - Stop passing actionType to TopSites methods, since it's ignored. r?jteow!
48 bytes, text/x-phabricator-request
Details | Review

test_top_sites.js currently imports actionTypes from Actions.sys.mjs, but it doesn't look like anything in TopSites.sys.mjs actually checks the type... so I think we can probably drop it altogether.

Whiteboard: [hnt-trainhop]
Blocks: 1949511
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3f543ad004a9 Stop passing actionType to TopSites methods, since it's ignored. r=jteow

https://hg.mozilla.org/mozilla-central/rev/3f543ad004a9

Status: NEW → RESOLVED
Closed: 8 months ago
status-firefox138: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: