1953073 - Calculator: Adjust Formatting Rules

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Yazan Al Macki [:yazan]]

Since we are using scientific notation for large numbers, we don't need to display comma/period thousands formatting for calculator results.
We should also modify the current max significant figures rule, which will resolve https://bugzilla.mozilla.org/show_bug.cgi?id=1954066.

Comment 1

[Yazan Al Macki [:yazan]]

Attachment: Bug 1953073 - Modify calc result formatting to fix issues with signficant digits and unnecessary grouping. r?jteow

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34cbfeb4df32
Modify calc result formatting to fix issues with signficant digits and unnecessary grouping. r=fluent-reviewers,urlbar-reviewers,bolsson,jteow

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/34cbfeb4df32

Comment 4

[Yazan Al Macki [:yazan]]

Attachment: Bug 1953073 - Modify calc result formatting to fix issues with signficant digits and unnecessary grouping. r?jteow

Original Revision: https://phabricator.services.mozilla.com/D241869

Comment 5

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Users may see incorrect calculations with large numbers
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Ensure 1000000000 + 2 and all calculations are correctly performed.
• Risk associated with taking this patch: Low
• Explanation of risk level: This patch only changes certain formatting rules to prevent incorrect calculations in certain scenarios, and to improve readability/consistency of results.
• String changes made/needed: I've added a new string, but it consists of only symbols/numbers, and would be the same for most locales
• Is Android affected?: no

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/fdc704a4e3c9

Comment 7

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build from 2025-03-11, on Windows 11.
Verified as fixed on the latest Nightly 138.0a1 (20250319204742) and latest Beta 137.0b8 (20250319094417) on Windows 11, macOS 11, Ubuntu 22. Large numbers are now displayed correctly without unnecessary grouping, using proper formatting and scientific notation when needed and the calculations are accurate.