1955018 - Calculator: Make Formatting Rules Consistent for Negative Numbers

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement)

Description

[Yazan Al Macki [:yazan]]

The changes on 1953073 should apply to negative numbers as well

Comment 1

[Yazan Al Macki [:yazan]]

Attachment: Bug 1955018 - Make calculator formatting consistent for negative numbers. r?jteow

Comment 2

[Yazan Al Macki [:yazan]]

Attachment: Bug 1955018 - Make calculator formatting consistent for negative numbers. r?jteow

Original Revision: https://phabricator.services.mozilla.com/D242157

Comment 3

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Incosistent formatting for negative numbers
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Ensure negative calculator results follow the same formatting rules as positive results
• Risk associated with taking this patch: Low
• Explanation of risk level: Limited to calculator result formatting
• String changes made/needed: N/A
• Is Android affected?: no

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55fa48248f8b
Make calculator formatting consistent for negative numbers. r=jteow,urlbar-reviewers

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/55fa48248f8b

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/856a4d764961

Comment 7

[Giorgia Nichita, Release Desktop QA]

I was able to reproduce this issue on an affected Nightly build (2025-03-19) on Windows 10.
After testing the latest Nightly (20250321040811) on Windows 10, Windows 11, macOS 11, and Ubuntu 22, I can confirm that the issue has been resolved. The calculator now applies consistent formatting to negative numbers, ensuring they follow the same rules as positive numbers. The results are displayed correctly and no inconsistencies were observed.

Leaving this bug open until Monday when the official beta build becomes available for further testing.

Comment 8

[Giorgia Nichita, Release Desktop QA]

Verified as fixed on Firefox 137.0b9 (20250321113016) using Windows 10, Windows 11, macOS 11, and Ubuntu 22.