1953261 - Trim Custom DoH Provider URI in DohUrlValidator

Status: RESOLVED FIXED

(Firefox for Android :: Browser Engine, defect)

Description

[Paul [pwd]]

Steps to reproduce

1. Copy custom provider URI from NextDNS
2. Paste into custom DOH setting

Expected behavior

URI is trimmed of trailing whitespace and accepted

Actual behavior

Errors out

Device information

• Firefox version: Nightly
• Android device model: Pixel 8 Pro
• Android OS version: 15

Any additional information?

Comment 1

[Sean Kim [:sekim]]

Attachment: Bug 1953261 - [DoH on Android] Trim Custom DoH Provider URI in DohUrlValidator r=sfamisa

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd7afd6d1a9c
[DoH on Android] Trim Custom DoH Provider URI in DohUrlValidator r=sfamisa,android-reviewers

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/cd7afd6d1a9c

Comment 4

[Sean Kim [:sekim]]

Attachment: Bug 1953261 - [DoH on Android] Trim Custom DoH Provider URI in DohUrlValidator

Original Revision: https://phabricator.services.mozilla.com/D241088

Comment 5

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: N/A
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: Implements a fix for Bug 1934262, behind a secret setting. Fix verified in Nightly.
• String changes made/needed: N/A
• Is Android affected?: yes

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9474776 [details]
Bug 1953261 - [DoH on Android] Trim Custom DoH Provider URI in DohUrlValidator

Moving to consideration for a release uplift now that 138 is in beta