1934262 - [DoH on Android] Add DoH to the settings UI in Fenix (as a secret setting)

Status: RESOLVED FIXED

(Firefox for Android :: Browser Engine, enhancement)

Description

[Sean Kim [:sekim]]

Once a GeckoView API is available in Fenix the next step is exposing the settings in the UI so users have a way to opt-out of DoH rollout or to manually choose the DoH behaviour and provider they want.

Implementing this would be desirable even if it were not a prerequisite for rolling out DoH to specific countries.

Comment 1

[Sean Kim [:sekim]]

Attachment: Bug 1934262 - [DoH on Android] Part 4: Setup for DoH settings UI in Fenix r=#android

Comment 2

[Sean Kim [:sekim]]

Attachment: Bug 1934262 - [DoH on Android] Part 3: Define states, actions, reducer, and middleware for DohSettings r=#android

Comment 3

[Sean Kim [:sekim]]

Attachment: Bug 1934262 - [DoH on Android] Part 1: Add prefs for DoH Settings UI in Fenix r=#android

Comment 4

[Sean Kim [:sekim]]

Attachment: Bug 1934262 - [DoH on Android] Part 5: Add root screen for the DoH settings r=#android

Comment 5

[Sean Kim [:sekim]]

Attachment: Bug 1934262 - [DoH on Android] Part 6: Add information screen (Default, Increased, Max) for the DoH settings r=#android

Comment 6

[Sean Kim [:sekim]]

Attachment: Bug 1934262 - [DoH on Android] Part 7: Add exceptions screen (ExceptionsListScreen/AddExceptionScreen) for the DoH settings r=#android

Comment 7

[Sean Kim [:sekim]]

Attachment: Bug 1934262 - [DoH on Android] Part 8: Add tests for DoH on Android r=#android

Comment 8

[Sean Kim [:sekim]]

Attachment: Bug 1934262 - [DoH on Android] Part 2: Add a url validator for the DoH settings r=valentin,#android

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c7486880f44
[DoH on Android] Part 1: Add prefs for DoH Settings UI in Fenix r=android-reviewers,sfamisa,android-l10n-reviewers,delphine
https://hg.mozilla.org/integration/autoland/rev/84bbfef81b93
[DoH on Android] Part 2: Add a url validator for the DoH settings r=valentin,android-reviewers,sfamisa
https://hg.mozilla.org/integration/autoland/rev/8c4fe33c9c51
[DoH on Android] Part 3: Define states, actions, reducer, and middleware for DohSettings r=android-reviewers,sfamisa
https://hg.mozilla.org/integration/autoland/rev/f18b1830c29f
[DoH on Android] Part 4: Setup for DoH settings UI in Fenix r=sfamisa,android-reviewers
https://hg.mozilla.org/integration/autoland/rev/fcf2a50e6390
[DoH on Android] Part 5: Add root screen for the DoH settings r=android-reviewers,sfamisa
https://hg.mozilla.org/integration/autoland/rev/30789ba24560
[DoH on Android] Part 6: Add information screen (Default, Increased, Max) for the DoH settings r=android-reviewers,sfamisa
https://hg.mozilla.org/integration/autoland/rev/0e5e6590872f
[DoH on Android] Part 7: Add exceptions screen (ExceptionsListScreen/AddExceptionScreen) for the DoH settings r=android-reviewers,sfamisa
https://hg.mozilla.org/integration/autoland/rev/ba5d98bd4f04
[DoH on Android] Part 8: Add tests for DoH on Android r=android-reviewers,sfamisa

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2c7486880f44
https://hg.mozilla.org/mozilla-central/rev/84bbfef81b93
https://hg.mozilla.org/mozilla-central/rev/8c4fe33c9c51
https://hg.mozilla.org/mozilla-central/rev/f18b1830c29f
https://hg.mozilla.org/mozilla-central/rev/fcf2a50e6390
https://hg.mozilla.org/mozilla-central/rev/30789ba24560
https://hg.mozilla.org/mozilla-central/rev/0e5e6590872f
https://hg.mozilla.org/mozilla-central/rev/ba5d98bd4f04

Comment 11

[Pascal Chevrel (relman team) -> :pascalc]

Sean, this looks like something that should go into our release notes, could you request an addition here so as that we don't forget about it? Thanks!

https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination#Nomination_in_Bugzilla

Comment 12

[Sean Kim [:sekim]]

(In reply to Pascal Chevrel:pascalc from comment #11)

Sean, this looks like something that should go into our release notes, could you request an addition here so as that we don't forget about it? Thanks!

https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination#Nomination_in_Bugzilla

Would we need to add this to release notes even if the patch is not enabled yet? (only available as a secret setting)

Comment 13

[Pascal Chevrel (relman team) -> :pascalc]

(In reply to Sean Kim from comment #12)

(In reply to Pascal Chevrel:pascalc from comment #11)

Sean, this looks like something that should go into our release notes, could you request an addition here so as that we don't forget about it? Thanks!

https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination#Nomination_in_Bugzilla

Would we need to add this to release notes even if the patch is not enabled yet? (only available as a secret setting)

In this case, no we don't :)