1953394 - Pausing on a location outside of the current viewport horizontally wouldn't move the paused location in center of the screen

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

While pausing in a non-visible location, which is up/down vertically, we would move the paused line in the middle of the codemirror viewport,
we don't do that for locations on left/right of the current viewport.
Instead, we only show the first character on the left or right edges of the current viewport.

As soon as the paused location isn't visible, we should move the viewport to make it so that the paused location is in the middle of the viewport.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1953394 - [devtools] Scroll to center new pause location with column being out of the viewport.

Before this patch, it would only make the column visible on the edge of the viewport,
so that we could only see the breakpoint marker, and/or only the first character after the pause location.

With this patch, if the paused location is visible, nothing happens.
But if the paused location is outside of the viewport, the paused location is centered horizontally.

Also remove the unused third argument of Editor's scrollTo.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccec3a38ebaf
[devtools] Scroll to center new pause location with column being out of the viewport. r=devtools-reviewers,bomsy

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ccec3a38ebaf