1953580 - Ensure addonsSearchDetection getMatchPatterns API methods defer accessing Services.search to after application startup is past first paint

Status: RESOLVED FIXED

(WebExtensions :: General, task, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

Since Bug 1938155 landed in mozilla-central the addons-search-detection builtin addon is now being loaded along with the other system addons, for addons-search-detection specifically that is earlier during application startup then it used to be before Bug 1938155 (before that change the addons-search-detection builtin used to be manually installed from a BrowserGlue idle task).

The fact that addons-search-detection is now being installed earlier during application startup is very likely the root cause of the increased failure rate hit by browser_startup.js due to the SearchService.sys.mjs being loaded before the application startup got past the first paint phase (see Bug 1798750 comment 139).

This bugzilla issue is tracking applying changes on the addons-search-detection builtin addon side to ensure that addonsSearchDetection.getMatchPattern API method will defer accessing Services.search to after application startup got past the first paint, as also suggested in Bug 1798750 comment 137.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1953580 - Ensure addonsSearchDetection getMatchPatterns awaits for first paint before accessing Services.search. r?willdurand!,Gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ffc9c8ce107
Ensure addonsSearchDetection getMatchPatterns awaits for first paint before accessing Services.search. r=Gijs,willdurand

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/5ffc9c8ce107