Closed Bug 1938155 Opened 1 year ago Closed 11 months ago

Introducing new builtin system add-ons location

Categories

(Toolkit :: Add-ons Manager, task, P1)

Product:
Toolkit
Component:
Add-ons Manager
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
138 Branch
Tracking Flags:
Tracking Status
firefox138 --- fixed

People

(Reporter: baku, Assigned: baku)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [addons-jira])

Attachments

(5 files, 10 obsolete files)

Bug 1938155 - System to BuiltIn addons - part 1 - new startup approach, r?rpl
48 bytes, text/x-phabricator-request
Details | Review
Bug 1938155 - System to BuiltIn addons - part 3 - about:support, r?rpl
48 bytes, text/x-phabricator-request
Details | Review
Bug 1938155 - System to BuiltIn addons - part 2 - Cleanup the search-detection addon startup, r?rpl
48 bytes, text/x-phabricator-request
Details | Review
Bug 1938155 - System to BuiltIn addons - part 4 - Lock new builtins location and remove xpistate on failing to load manifest.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1938155 - System to BuiltIn addons - part 5 - Rename app-system-builtins to app-builtin-addons.
48 bytes, text/x-phabricator-request
Details | Review

In the webExt world, we are trying to deprecate system add-ons and replace them with built-in ones. This bug focuses on porting the webCompact add-on.

Attachment #9444396 - Attachment description: Bug 1938155 - webcompat as a builtin add-on, r?rpl,twisniewski → Bug 1938155 - System to BuiltIn addons - part 1 - WebCompat add-on, r?rpl,twisniewski
Summary: move webCompact system addon into builtins in omni.ja → move webCompat system addon into builtins in omni.ja

Comment on attachment 9444577 [details]
WIP: Bug 1938155 - System to BuiltIn addons - part 3 - Screenshots add-on

Revision D232639 was moved to bug 1937477. Setting attachment 9444577 [details] to obsolete.

Attachment #9444577 - Attachment is obsolete: true
Severity: -- → N/A
Priority: -- → P3
Whiteboard: [addons-jira]
Attachment #9444396 - Attachment description: Bug 1938155 - System to BuiltIn addons - part 1 - WebCompat add-on, r?rpl,twisniewski → Bug 1938155 - System to BuiltIn addons - part 3 - WebCompat add-on, r?rpl,twisniewski
Attachment #9444576 - Attachment description: WIP: Bug 1938155 - System to BuiltIn addons - part 2 - PictureInPicture add-on → WIP: Bug 1938155 - System to BuiltIn addons - part 4 - PictureInPicture add-on
Attachment #9462540 - Attachment description: WIP: Bug 1938155 - System to BuiltIn addons - part 2 - about:support → Bug 1938155 - System to BuiltIn addons - part 2 - about:support, r?rpl
Attachment #9444576 - Attachment description: WIP: Bug 1938155 - System to BuiltIn addons - part 4 - PictureInPicture add-on → Bug 1938155 - System to BuiltIn addons - part 4 - PictureInPicture add-on, r?rpl
Attachment #9462540 - Attachment is obsolete: true
Attachment #9462539 - Attachment is obsolete: true
Attachment #9444578 - Attachment description: WIP: Bug 1938155 - System to BuiltIn addons - part 4 - FormAutofill add-on → Bug 1938155 - System to BuiltIn addons - part 6 - FormAutofill add-on, r?rpl
Attachment #9444579 - Attachment description: WIP: Bug 1938155 - System to BuiltIn addons - part 5 - Report-Site-Issue add-on → Bug 1938155 - System to BuiltIn addons - part 7 - Report-Site-Issue add-on, r?rpl
Attachment #9444580 - Attachment is obsolete: true
Summary: move webCompat system addon into builtins in omni.ja → Consolidating built-in add-ons in tree
Component: General → Add-ons Manager
Priority: P3 → P1
Product: WebExtensions → Toolkit
Status: NEW → ASSIGNED
Summary: Consolidating built-in add-ons in tree → Introducing new builtin system add-ons location
Attachment #9463057 - Attachment is obsolete: true
Attachment #9462547 - Attachment is obsolete: true
Attachment #9444579 - Attachment is obsolete: true
Attachment #9444578 - Attachment is obsolete: true
Attachment #9444576 - Attachment is obsolete: true
Attachment #9462897 - Attachment description: Bug 1938155 - System to BuiltIn addons - part 8 - Cleanup the search-detection addon startup, r?rpl → Bug 1938155 - System to BuiltIn addons - part 2 - Cleanup the search-detection addon startup, r?rpl
Attachment #9444396 - Attachment is obsolete: true
Attachment #9462545 - Attachment description: Bug 1938155 - System to BuiltIn addons - part 2 - about:support, r?rpl → Bug 1938155 - System to BuiltIn addons - part 3 - about:support, r?rpl

This patch locks the app-system-builtins location (like the legacy app-system-defaults location) and ensures that xpi state for an
app-system-builtins addons that has hit failures on successfully loading their manifest (like the app-builtins location) to prevent
an XPIState with userDisabled true to stick across app/addon updates that will load the manifest successfully.

In addition to that this patch also includes:

  • tweaks to test_system_reset.js to cover these expected behaviors (and to adapt it to cover both the legacy xpi based app-system-defaults location
    and the new app-system-builtins).
  • tweaks to test_system_upgrades.js to account for the app-system-builtins location to be locked
Attachment #9468280 - Attachment description: Bug 1938155 - System to BuiltIn addons - part 4 - Lock app-system-builtins location and remove xpistate on failing to load manifest. → Bug 1938155 - System to BuiltIn addons - part 4 - Lock new builtins location and remove xpistate on failing to load manifest.
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1ef8c3ce26bf System to BuiltIn addons - part 1 - new startup approach, r=rpl https://hg.mozilla.org/integration/autoland/rev/773ffa5505a1 System to BuiltIn addons - part 2 - Cleanup the search-detection addon startup, r=rpl,firefox-desktop-core-reviewers ,mconley https://hg.mozilla.org/integration/autoland/rev/33212a164d8d System to BuiltIn addons - part 3 - about:support, r=rpl,fluent-reviewers,bolsson https://hg.mozilla.org/integration/autoland/rev/75b3ab804c41 System to BuiltIn addons - part 4 - Lock new builtins location and remove xpistate on failing to load manifest. r=willdurand https://hg.mozilla.org/integration/autoland/rev/3a07ac797a6b System to BuiltIn addons - part 5 - Rename app-system-builtins to app-builtin-addons. r=baku,willdurand

These failures are also caused by the backed out patch: https://treeherder.mozilla.org/logviewer?job_id=497338722&repo=autoland

Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4fec5503cdd6 System to BuiltIn addons - part 1 - new startup approach, r=rpl https://hg.mozilla.org/integration/autoland/rev/246a2690cb2c System to BuiltIn addons - part 2 - Cleanup the search-detection addon startup, r=rpl,firefox-desktop-core-reviewers ,mconley https://hg.mozilla.org/integration/autoland/rev/640c1a4809b1 System to BuiltIn addons - part 3 - about:support, r=rpl,fluent-reviewers,bolsson https://hg.mozilla.org/integration/autoland/rev/9bbcf3882229 System to BuiltIn addons - part 4 - Lock new builtins location and remove xpistate on failing to load manifest. r=willdurand https://hg.mozilla.org/integration/autoland/rev/fc223c74dab3 System to BuiltIn addons - part 5 - Rename app-system-builtins to app-builtin-addons. r=baku,willdurand
Regressions: 1951674
Blocks: 1952187
Attachment #9444396 - Attachment is obsolete: false

Comment on attachment 9444396 [details]
Bug 1938155 - System to BuiltIn addons - part 3 - WebCompat add-on, r?rpl,twisniewski

Revision D232530 was moved to bug 1948914. Setting attachment 9444396 [details] to obsolete.

Attachment #9444396 - Attachment is obsolete: true
Attachment #9444578 - Attachment is obsolete: false

Comment on attachment 9444578 [details]
Bug 1938155 - System to BuiltIn addons - part 6 - FormAutofill add-on, r?rpl

Revision D232640 was moved to bug 1948916. Setting attachment 9444578 [details] to obsolete.

Attachment #9444578 - Attachment is obsolete: true
See Also: → 1953580
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: