195388 - Clearing Download Manager History doesn't work

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[David Tenser [:djst]]

If you click on the Clear button under Download Manager History, only half of
the downloaded items are cleared.

Steps to reproduce:
1. Open the Download sidebar (Ctrl+E)
2. Download a few small files if you don't have a download history already
3. Select Tools > Options..., click Privacy, Download Manager History, and then
click Clear.

Actual results:
Only half of the items are removed from the list.

Comment 1

[Mike Connor [:mconnor]]

taking, patch coming

Comment 2

[Mike Connor [:mconnor]]

Attachment: patch to fix Clear Downloads functionality

this method works, and goes along with how the clear cookies function works. 
Why the existing method doesn't work isn't readily evident to me,  but given
that the cookies removal could use this method as well and doesn't, I figure
this is the best fix for the moment

Comment 3

[Mike Connor [:mconnor]]

Attachment: patch to fix Clear Downloads functionality

this method works, and goes along with how the clear cookies function works. 
Why the existing method doesn't work isn't readily evident to me,  but given
that the cookies removal could use that method as well and doesn't, I figure
this is the best fix for the moment

Comment 4

[noririty]

checked in.

Comment 5

[Simon Paquet [:sipaq]]

verified with 20030721 build on W2K

Comment 6

[Charles Fenwick]

*** Bug 213183 has been marked as a duplicate of this bug. ***