1953970 - Prepare parts of toolkit/components/places for TypeScript

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Mark Banner (:standard8)]

This is a collection of changes that we'll be using as we set-up TypeScript on the toolkit/components/places directory.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1953970 - Automatically fix issues relating to ESLint mozilla/valid-jsdoc configuration rules in toolkit places code. r?#places-reviewers!

This applies the ESLint fixes to the current production code.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1953970 - Add Glean typescript definitions for toolkit places metrics. r?#places-reviewers!

This defines the appropraite types so that TypeScript knows about the metrics definitions.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1953970 - Use cenums in mozISyncedBookmarksMirror to make it easier for TypeScript to handle the constants. r?#places-reviewers!

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1953970 - Fix TypeScript issues raised in BookmarkHTMLUtils.sys.mjs and SyncedBookmarksMirror.sys.mjs. r?#places-reviewers!.

This also changes Sqlite.sys.mjs so that TypeScript can use the OpenedConnection type from SyncedBookmarksMirror.sys.mjs.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ff849c057b2
Automatically fix issues relating to ESLint mozilla/valid-jsdoc configuration rules in toolkit places code. r=places-reviewers,daisuke
https://hg.mozilla.org/integration/autoland/rev/18119f894dfc
Add Glean typescript definitions for toolkit places metrics. r=places-reviewers,daisuke
https://hg.mozilla.org/integration/autoland/rev/16e7d5e27d59
Use cenums in mozISyncedBookmarksMirror to make it easier for TypeScript to handle the constants. r=places-reviewers,daisuke
https://hg.mozilla.org/integration/autoland/rev/27b398e13a67
Fix TypeScript issues raised in BookmarkHTMLUtils.sys.mjs and SyncedBookmarksMirror.sys.mjs. r=places-reviewers,daisuke.

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4ff849c057b2
https://hg.mozilla.org/mozilla-central/rev/18119f894dfc
https://hg.mozilla.org/mozilla-central/rev/16e7d5e27d59
https://hg.mozilla.org/mozilla-central/rev/27b398e13a67