1954136 - Fix TypeScript issues raised in History.sys.mjs, PlacesBackups.sys.mjs, and PlacesSyncUtils.sys.mjs

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[James Teow [:jteow]]

This is mostly an isolated and easy fix but getBookmarksTree returns a complex Data Structure that should be defined somewhere (probably PlacesUtils) first.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 1954136 - Fix Typescript and JSDoc issues in History.sys.mjs, PlacesBackups.sys.mjs, and PlacesSyncUtils.sys.mjs - r?standard8!

There is still an issue where nsINavHistoryService.TransitionType is not recognized as a type.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5785913a71c0
Fix Typescript and JSDoc issues in History.sys.mjs, PlacesBackups.sys.mjs, and PlacesSyncUtils.sys.mjs - r=Standard8

Comment 3

[amarc]

Backed out for causing xpcshell failures @ test_history_engine.js

• Backout link
• Push with failures
• Failure Log

Comment 4

[James Teow [:jteow]]

The test revealed the fact that one of the callers was passing a non-Date object to a helper function, which worked previously because of type coercion. I've re-submitted the patch for approval from the sync team.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6827920f38b
Fix Typescript and JSDoc issues in History.sys.mjs, PlacesBackups.sys.mjs, and PlacesSyncUtils.sys.mjs - r=Standard8,sync-reviewers,skhamis

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/a6827920f38b