1954087 - ./mach run -P d -purgecaches no longer works

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Mark Banner (:standard8)]

Following the change in bug 1953089, attempting to run ./mach run -P d -purgecaches no longer works:

./mach run -P d -purgecaches
It looks like you passed an unrecognized argument into mach.

The run command does not accept the arguments: -P -purgecaches

You have to specify an additional --, i.e. ./mach run -- -P d purgecaches.

Not sure if this is an intended change or not.

If it is going to be kept, then it needs announcing on the platform & firefox mailing lists, and the error message should be updated.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1953089

:sergesanspaille, since you are the author of the regressor, bug 1953089, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[[:sergesanspaille]]

Attachment: Bug 1954087 - Fix invalid parsing of mach run remaining args r=glandium

This actually fixes a bug introduced in #1953089.

Comment 3

[Thomas Wisniewski [:twisniewski]]

This is also breaking Fenix run:

mach run --app=fenix

   NameError: name 'fake_help' is not defined

  File "/Users/tom/moz/mozilla-unified/python/mozbuild/mozbuild/mach_commands.py", line 1628, in run
    assert not fake_help
               ^^^^^^^^^

Commenting out these two lines works around it:
https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/mach_commands.py#1627-1629

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbc6be3b69f4
Fix invalid parsing of mach run remaining args r=firefox-build-system-reviewers,nalexander

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/dbc6be3b69f4