1954293 - Remove privacy.partition.network_state

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Emilio Cobos Álvarez [:emilio]]

It's been on by default for years, so I think this is only about getting rid of / fixing tests?

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1954293 - Remove test-only usages of privacy.partition.network_state. r=#necko-reviewers

In preparation for removing it.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1954293 - Remove privacy.partition.network_state. r=#necko-reviewers

It's been on for years, there's no point in keeping the old code-paths.

Comment 5

[BugBot [:suhaib / :marco]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:emilio, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Yes, there are some failures I need to investigate.

Comment 7

[notyouremailreally]

I don't believe removing this is a good Idea as it's a toggle that provides a valuable trade-off of better performance and bandwidth usage over pure privacy.
Also removing it would mean that bug 1687569 is unsolvable for end users as far as I understand.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1a895fc68063
https://hg.mozilla.org/integration/autoland/rev/2c21a5db5da7
Remove test-only usages of privacy.partition.network_state. r=necko-reviewers,extension-reviewers,anti-tracking-reviewers,robwu,kershaw,timhuang
https://github.com/mozilla-firefox/firefox/commit/48a62575834a
https://hg.mozilla.org/integration/autoland/rev/a218a4cb6be1
Remove privacy.partition.network_state. r=necko-reviewers,anti-tracking-reviewers,valentin,timhuang
https://github.com/mozilla-firefox/firefox/commit/b36d3ffd65a8
https://hg.mozilla.org/integration/autoland/rev/e0a4f1c8937e
apply code formatting via Lando

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5e0b592101dc
https://hg.mozilla.org/integration/autoland/rev/ad1b18bbb128
Remove privacy.partition.network_state from another test.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9a9fadaffa5a
https://hg.mozilla.org/integration/autoland/rev/27f05f28bba1
Fix lint failure in browser_scriptCache_partition.js

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2c21a5db5da7
https://hg.mozilla.org/mozilla-central/rev/a218a4cb6be1
https://hg.mozilla.org/mozilla-central/rev/e0a4f1c8937e
https://hg.mozilla.org/mozilla-central/rev/ad1b18bbb128
https://hg.mozilla.org/mozilla-central/rev/27f05f28bba1

Comment 12

[Emilio Cobos Álvarez [:emilio]]

(In reply to notyouremailreally from comment #7)

I don't believe removing this is a good Idea as it's a toggle that provides a valuable trade-off of better performance and bandwidth usage over pure privacy.

Well it's not privacy, it's the web security model :)

A lot of things were already partitioned without checking the pref, and having this configuration completely untested (or, even worse, papering bugs with partitioning enabled) is bad.