1954416 - Glitches when resizing browser window with layer compositor enabled

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

With layer compositor enabled, glitches are presented during resizing window like Bug 1578330.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gw, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: temporal patch - Readback to PNG from swap chain's D3D11Texture2D

With the patch, during resizing, scaling of rendering seemed not correct.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1954416 - Change NativeSurface::dimensions in Renderer::composite_simple() as to use frame.device_rect.size()

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fb5b781fa94
Change NativeSurface::dimensions in Renderer::composite_simple() as to use frame.device_rect.size() r=gfx-reviewers,lsalzman

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2fb5b781fa94

Comment 6

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 15-29 Aug, please ni? :mboldan]]

Hello! Unfortunately, I cannot reproduce this on Windows 10x64 using Firefox 138.0a1 (20250316213034) with gfx.webrender.layer-compositor:true. The only glitches I see when resizing the browser are on the right/bottom side when I grab the window to resize it from the left or top side, but these issues can also be seen with gfx.webrender.layer-compositor:false.. Does anyone know if I'm missing something here? Thank you!

Comment 7

[Sotaro Ikeda [:sotaro]]

I checked with the following. And I confirmed the glitch in task bar with pref gfx.webrender.layer-compositor:true during resizing right side of window.
https://ftp.mozilla.org/pub/firefox/nightly/2025/03/2025-03-16-04-06-36-mozilla-central/firefox-138.0a1.en-US.win64.zip

WebRender layer compositor is not used even with the pref if WebRender compositor is blocked. Comment 6 could happen.

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 15-29 Aug, please ni? :mboldan]]

(In reply to Sotaro Ikeda [:sotaro] from comment #7)

I checked with the following. And I confirmed the glitch in task bar with pref gfx.webrender.layer-compositor:true during resizing right side of window.
https://ftp.mozilla.org/pub/firefox/nightly/2025/03/2025-03-16-04-06-36-mozilla-central/firefox-138.0a1.en-US.win64.zip

WebRender layer compositor is not used even with the pref if WebRender compositor is blocked. Comment 6 could happen.

Thank you for the response. I have tried multiple times with the provided build from above, and unfortunately, I cannot reproduce the issue. I have enabled gfx.webrender.layer-compositor:true/ gfx.webrender.compositor.force-enabled:true, and eventually gfx.webrender.all:true, and still cannot reproduce during resizing the right side of the window.