195443 - xmlrpc broken stream closed pre-maturely

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Mike Lee]

xmlrpc is broken in the nightlies when using string as one of the parameters. I
expect its fall out from CString changes. Changing 

obj=obj.QueryInterface(Components.interfaces['nsISupports' + sType]); to
obj=obj.QueryInterface(Components.interfaces['nsISupportsC' + sType]); fixes the
issue. Of course you would need to add copy the code for the char type. 
http://lxr.mozilla.org/seamonkey/source/extensions/xml-rpc/src/nsXmlRpcClient.js#482


Maybe a more eligant fix would be to return CString at
http://lxr.mozilla.org/seamonkey/source/extensions/xml-rpc/src/nsXmlRpcClient.js#590
instead of just the stream, but I didnt test this.


Another issue with the xmlrpc is that after calling the method it return an
error message:
Error! (80470002) Component returned failure code: 0x80470002
(NS_BASE_STREAM_CLOSED) [nsIScriptableInputStream.available]
I suspect the stream is closed pre-maturely. But I havent found time to
investigate this futher.

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Reassigning to Samuel who owns XML-RPC.

Comment 2

[Kevin A. Burton]

I believe I am running into this bug in 1.2.1 as well.  I will take a look and
see if I can come up with a patch.

Comment 3

[Kevin A. Burton]

It isn't just the nightlies .... 1.3b and 1.2.1 exhibit the same problem.

Comment 4

[Kevin A. Burton]

I have confirmed that updating my nsXmlRpcClient.js from Mozilla 1.3b with 

obj=obj.QueryInterface(Components.interfaces['nsISupportsC' + sType]);

DOES fix the problem...

Comment 5

[Samuel Sieb]

Bug 186257 is the string problem.  I'll keep this one open for the stream
problem.  Mike, can you provide any more details?  Do you still see it? 

Comment 6

[Kevin A. Burton]

Can somone change the summary of this to:

"strings within xmlrpc broken due to CString changes"

The current summary is way to vague...

Can we get a fix for this integrated?

Comment 7

[Mike Lee]

Kevin the bug about CString is now 186257. The fix should land pretty soon. This
bug is now about the stream problem I'm having as Samuel wanted. Samuel I havent
had time to check it further, I'll do so soon.

Comment 8

[Samuel Sieb]

Actually, I do see this problem now.

Comment 9

[Anand Aiyer]

nsIScriptableInputStream.available returns NS_BASE_STREAM_CLOSED by some 
nsIInputStream implementations to indicate EOF. So XMLRPC fails when 
PushbackInputStream.prototype.available calls the stream's available.

Comment 10

[Anand Aiyer]

Attachment: Fixes the problem

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 196541 [details] [diff] [review]
Fixes the problem

too late to take non-critical changes into this release.

Comment 12

[Samuel Sieb]

Requesting approval for the patch because xml-rpc has been broken on trunk for a
long time due to work on bug 197087.  This small patch which only affects
xml-rpc anyways will make it work until bug 197087 gets done.

Comment 13

[Samuel Sieb]

Oops, I don't mean that bug 197087 caused the breakage, I meant that bug 197087
was going to fix it, but it's been taking a long time to get it done.

Comment 14

[James Ross]

Comment on attachment 196541 [details] [diff] [review]
Fixes the problem

Checked in to 1.8 branch on behalf of ssieb.

Comment 15

[Worcester12345]

(In reply to comment #14)
> (From update of attachment 196541 [details] [diff] [review] [edit])
> Checked in to 1.8 branch on behalf of ssieb.
> 

I thought all checkins went to trunk first (to "bake"). Especially true here
since this is a trunk bug. ???

Comment 16

[James Ross]

It was given approval to land on the branch without any such requirement being
made. You'd have to ask drivers/Asa why the trunk "baking" was not required in
this case (though I can make a few guesses).

Comment 17

[Samuel Sieb]

fixed by bug 197087