1954608 - Disable discard element

Status: RESOLVED FIXED

(Core :: SVG, task)

Comment 1

[Robert Longson [:longsonr]]

Attachment: Bug 1954608 - disable discard element r=emilio

Comment 2

[Robert Longson [:longsonr]]

This needs to land only in beta so that we have more time to fix existing discard issues.

Comment 3

[Robert Longson [:longsonr]]

Comment on attachment 9472553 [details]
Bug 1954608 - disable discard element r=emilio

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: bug 1954247
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): reverts us to where we are in current release i.e. disables a new feature we've not yet gone live with.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 4

[Pascal Chevrel:pascalc]

Comment on attachment 9472553 [details]
Bug 1954608 - disable discard element r=emilio

That will go into beta 8 tomorrow.

Comment 5

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/59754fd85dd0

Comment 6

[Pascal Chevrel:pascalc]

FYI, the release note for this feature in 137 was also removed

Comment 7

[Frederik Braun [:freddy] (OOO until April 28th)]

I would like to make the case to unship <discard>, given the standards situation.

I realize I should have mentioned this as part of the intent to prototype or the intent to ship thread and my apologies for missing it.

<discard> seems to be implemented nowhere with no clear public motion to change that in any kind of recent working group discussion. Our experience with unscripted, declarative abilities to change the DOM tree (see also: <animate>) is causing significant implementation challenges while also introducing serious questions about what is and is not acceptable markup in scenarios that do not allow scripts (like iframe sandbox).

I would like us to disable the API as planned in this bug as it is already ongoing.
I would also like to see stronger standards positions from other browsers to make this feasibly a part of the web. I haven't seen anything from other browsers since this was unshipped from Chrome in 2019 (6 years ago).

Comment 8

[Tantek Çelik]

+1 to unship discard. This is not a strategic leadership item for us, and by default we should be reducing surface.

Comment 9

[Robert Longson [:longsonr]]

Attachment: Bug 1954608 - disable discard element r=dholbert

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae8af0edf737
disable discard element r=dholbert

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ae8af0edf737

Comment 12

[Pascal Chevrel:pascalc]

Note removed from our nightly release notes.

Comment 13

[Frederik Braun [:freddy] (OOO until April 28th)]

Thank you for disabling this feature, Robert. I understand that this is frustrating.

Comment 14

[Hamish Willee]

Frustrating. FYI, have updated the compatibility data to reflect this, and also reverted to MDN FF137 release note