1954610 - Fix transparent-text-* LCP Web Platform Tests

Status: RESOLVED FIXED

(Core :: DOM: Performance APIs, defect)

Description

[Justin Link]

Both of these tests have similar, questionable behavior - they wait until the "larger_text" element is added to the LCP entries list, and then assert that there is exactly one item in that list. This doesn't really make sense, as there are two LCP-eligible elements on the page and there is no guarantee on the order, in time, in which they will get added.
To fix this, we should wait until both elements get added to the list and then confirm that the correct one is in the last position in that list.

Comment 1

[Justin Link]

Attachment: Bug 1954610: Fixed wpt transparent-text tests to verify 'last' entry rather than look at count r=sefeng

rather than look at count r=sfeng

Comment 2

[Justin Link]

Attachment: Bug 1954610: Resolve the promise once there are two entries in the list, rather than once the tested one is there. r=sefeng

rather than once the tested one is there. r=sfeng

Depends on D241892

Comment 3

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:bas.schouten, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Justin Link]

https://github.com/web-platform-tests/interop/issues/948 has been created to facilitate any potential discussion on this topic.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72d7a5668f5c
Fixed wpt transparent-text tests to verify 'last' entry rather than look at count r=sefeng

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/51945 for changes under testing/web-platform/tests

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/72d7a5668f5c

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot