1972151 - Image-upscaling test #4 on LCP Web Platform Tests is failing

Status: RESOLVED FIXED

(Core :: DOM: Performance APIs, defect)

Description

[Justin Link]

Test #4 of the "image-upscaling" LCP WPT test is currently failing with the assert "An upscaled image (width/height) should report the natural size".

Comment 1

[Justin Link]

The reason for this test failing is precision loss - we do some imperfect floating point math and then convert the result to an integer at the end.

Re-arranging this math a little bit improves things enough that we now produce the correct result.

Comment 2

[Justin Link]

Attachment: Bug 1972151: Re-arrange some math a little bit to avoid some unnecessary precision loss in floating point calculations. r=sefeng

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/721ddbc3d36c
https://hg.mozilla.org/integration/autoland/rev/a9300ff2424b
Re-arrange some math a little bit to avoid some unnecessary precision loss in floating point calculations. r=sefeng

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/76b08d1b89ac
https://hg.mozilla.org/integration/autoland/rev/de354c6d59d4
Revert "Bug 1972151: Re-arrange some math a little bit to avoid some unnecessary precision loss in floating point calculations. r=sefeng" for causing wpt failures at image-upscaling.html

Comment 5

[Cristina Horotan [:chorotan]]

Backed out for causing wpt failures

Backout link

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/517649fdc478
https://hg.mozilla.org/integration/autoland/rev/731309819af2
Re-arrange some math a little bit to avoid some unnecessary precision loss in floating point calculations. r=sefeng

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/731309819af2