Closed Bug 1955257 Opened 7 months ago Closed 6 months ago

The UK sponsored suggestions are not properly dismissed using their menu

Categories

(Firefox :: Address Bar, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox136 --- unaffected
firefox137 --- unaffected
firefox138 --- verified

People

(Reporter: cfat, Assigned: adw)

References

Details

(Whiteboard: [sng])

[Affected versions]:

  • Firefox Nightly 138.0 (Build ID: 20250319204742)

[Affected Platforms]:

  • Windows 11 x64
  • Ubuntu 24.04 x64
  • macOS 15.3

[Prerequisites]:

  • Have Firefox Nightly 138 installed.
  • Set the following prefs, then restart the browser:
    -> browser.urlbar.quicksuggest.enabled = true
    -> browser.urlbar.suggest.quicksuggest.sponsored = true
    -> browser.urlbar.suggest.quicksuggest.nonsponsored = true
    -> browser.search.region = GB

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites.
  2. Open a new tab.
  3. Focus the Address Bar and type “adi”.
  4. Hover the Adidas suggestion and click the “...” menu.
  5. Click the “Dismiss this suggestion” option.
  6. Focus the Address Bar and continue to type “das”.
  7. Observe the results.

[Expected result]:

  • The sponsored suggestion for the “adidas” keyword is not displayed.

[Actual result]:

  • The sponsored suggestion for the “adidas” keyword is displayed.

[Notes]:

  • This issue is not reproducible with the non-sponsored suggestions.
  • Here are the logs registered for this behavior.
  • Here is a screen recording with the issue.
Whiteboard: [sng]
Assignee: nobody → adw
Status: NEW → ASSIGNED
Priority: -- → P1
Depends on: 1955892

Can (cbguder) uploaded new data to RS today that fixed this, and I was able to verify it. Specifically, the STR in comment 0 and similar STR are fixed now. There is still one known issue where dismissals may reappear after a day due to the fact that dismissals are keyed on URL and AMP may change their URLs daily. (It's not clear to me whether they're guaranteed to change daily. It sounds like not.) There's not a bug on file specifically for that but we can address it with bug 1955892.

I'll mark this as fixed in 138 even though the fix was totally server-side.

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
No longer depends on: 1955892
Resolution: --- → FIXED
See Also: → 1955892

(In reply to Drew Willcoxon :adw from comment #1)

There's not a bug on file specifically for that but we can address it with bug 1955892.

Bug 1960786 is where we'll fix this.

See Also: → 1960786

I have verified this issue on the latest Firefox Beta 138.0b7 (Build ID: 20250414092054) on Windows 11 x64, macOS 15.3, and Ubuntu 24.04 x64.

  • The UK sponsored suggestions are dismissed correctly and no longer appear when typing the same keyword.

Marking this report as Verified.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.