Closed
Bug 1955892
Opened 7 months ago
Closed 6 months ago
Allow suggestions to be dismissed by dismissal/block keys and not only URLs
Categories
(Application Services :: Suggest, task, P1)
Application Services
Suggest
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: adw, Assigned: adw)
References
Details
(Whiteboard: [sng])
Attachments
(1 file)
We discussed this on Slack -- in the short term at least, non-U.S. AMP suggestions need to be dismissable by something other than their URLs. Rather than hardcode different dismissal logic per country, we can generalize the concept of dismissal-by-URL to dismissal-by-arbitrary-key, and the dismissal keys can be part of the suggestions data. Can says that tiles dismissals work like this -- they're called block keys in that context. When a suggestion is dismissed, we would store the dismissal key in the DB instead of the URL. For non-AMP suggestions, we can continue to fall back to URL for dismissal keys.
Updated•7 months ago
|
Comment 1•7 months ago
|
||
| Assignee | ||
Comment 2•6 months ago
|
||
Wontfixing in favor of bug 1960786.
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•