1955287 - Allow the ability to add a tab to a closed group in the context menu

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement, P2)

Description

[Amy Lee [:amylee] UX]

Steps to reproduce [can add screenshots or video recordings for reference]:

Have at least 1 closed group and 1 opened group on the tab strip

Expected behavior [What should have happened?]:

When I right click on a tab in the tab strip and go to "Add Tab to Group" I can add the tab to opened and closed groups (with the favicon shown as solid or outlined depending on if the group is opened or closed)

Actual behavior [What actually happened?]:

I can only add the tab to a group that is opened in the tab strip

Comment 1

[Amy Lee [:amylee] UX]

Hi,

Here is the spec to show the updated Add Tab to Group context menu

https://www.figma.com/design/f6J2lH6XDxLxyzOLr2E8oE/Tab-Grouping-Spec?node-id=20098-98959&t=Wh1VINM0298VcNLy-1

Comment 2

[Jeremy Swinarton]

Attachment: Bug 1955287: Add tab to closed group from context menu r?dwalker,sthompson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/13704220d3dd
https://hg.mozilla.org/integration/autoland/rev/2bd60121eb78
Add tab to closed group from context menu r=sthompson,fluent-reviewers,sessionstore-reviewers,tabbrowser-reviewers,bolsson,sfoster

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2bd60121eb78

Comment 5

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Verified as fixed using Firefox 142.0b9 on macOS 14, Windows 11 and Ubuntu 22.04. Tabs can be added to a closed group in the context menu and the UI corresponds with the specs from Comment 1.